test(x/slashing): add infractions test #21387
Conversation
JulianToledano
added
the
backport/v0.52.x
WalkthroughWalkthroughThe changes involve updating URLs in the README for the Cosmos SDK slashing module to direct users to the latest documentation version, modifying method signatures in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (4)
- x/slashing/README.md (2 hunks)
- x/slashing/keeper/grpc_query.go (1 hunks)
- x/slashing/keeper/infractions_test.go (1 hunks)
- x/slashing/keeper/migrations.go (1 hunks)
Files skipped from review due to trivial changes (3)
- x/slashing/README.md
- x/slashing/keeper/grpc_query.go
- x/slashing/keeper/migrations.go
Additional context used
Path-based instructions (1)
x/slashing/keeper/infractions_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
Additional comments not posted (7)
x/slashing/keeper/infractions_test.go (7)
3-16: Imports look good.The import statements are appropriate and necessary for the functionality being tested.
18-126: Comprehensive test coverage forHandleValidatorSignature.The test cases cover various scenarios, including valid validators, jailed validators, and different signing info conditions. The use of mock expectations and assertions is appropriate. Consider adding edge cases if applicable.
39-52: Test case "ok validator" is well-structured.The test case correctly verifies the behavior for a valid validator scenario.
53-59: Test case "jailed validator" is correctly implemented.The test case accurately handles the jailed validator scenario.
60-71: Test case "signingInfo startHeight > height" is well-structured.The test case effectively captures the error condition when the signing info start height is greater than the current height.
72-85: Test case "absent" is appropriately structured.The test case correctly handles the scenario where the validator is absent.
86-100: Test case "punish validator" is well-structured.The test case effectively tests the punishment logic for a validator.
(cherry picked from commit 28c792b)
Co-authored-by: Julián Toledano <[email protected]>
Description
Ref:
#20955
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Documentation
Bug Fixes
Tests
HandleValidatorSignaturemethod, validating various scenarios for validator signatures to ensure robust functionality.