chore: run make protogen #21378
chore: run make protogen #21378
Conversation
WalkthroughWalkthroughThe changes reflect a significant refactor across several files in the Cosmos SDK, focusing on simplifying protocol buffer initializations, modifying message structures, and updating dependencies. Key adjustments include the removal of certain import statements, updates to protobuf message definitions, and enhancements to configuration settings. These alterations aim to improve code maintainability, streamline dependencies, and enhance integration within the Go ecosystem. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (7)
depinject/internal/appconfig/buf.lockis excluded by!**/*.lockdepinject/internal/appconfiggogo/buf.lockis excluded by!**/*.lockdepinject/internal/appconfiggogo/testpb/test.pb.gois excluded by!**/*.pb.gotestutil/x/counter/types/module.pb.gois excluded by!**/*.pb.gox/consensus/types/query.pb.gois excluded by!**/*.pb.gox/consensus/types/tx.pb.gois excluded by!**/*.pb.gox/staking/types/staking.pb.gois excluded by!**/*.pb.go
Files selected for processing (4)
- api/cosmos/consensus/v1/query.pulsar.go (2 hunks)
- api/cosmos/consensus/v1/tx.pulsar.go (2 hunks)
- depinject/internal/appconfig/buf.gen.pulsar.yaml (1 hunks)
- depinject/internal/appconfig/testpb/test.pulsar.go (2 hunks)
Additional context used
Path-based instructions (3)
api/cosmos/consensus/v1/query.pulsar.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.api/cosmos/consensus/v1/tx.pulsar.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.depinject/internal/appconfig/testpb/test.pulsar.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (3)
depinject/internal/appconfig/buf.gen.pulsar.yaml (1)
2-5: Configuration Update Approved.The addition of the
managedsection withenabled: trueandgo_package_prefixis a positive step towards better management of generated code.depinject/internal/appconfig/testpb/test.pulsar.go (2)
5-5: Verify the new import path.The import path has been updated to
cosmossdk.io/api/cosmos/app/v1alpha1. Ensure that this path is correct and aligns with the intended version of the Cosmos SDK API.
2347-2354: Verify changes in the byte array descriptor.The
file_testpb_test_proto_rawDeschas been modified. Ensure that these changes are intentional and correctly reflect the updated protocol buffer definitions.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (7)
depinject/internal/appconfig/buf.lockis excluded by!**/*.lockdepinject/internal/appconfiggogo/buf.lockis excluded by!**/*.lockdepinject/internal/appconfiggogo/testpb/test.pb.gois excluded by!**/*.pb.gotestutil/x/counter/types/module.pb.gois excluded by!**/*.pb.gox/consensus/types/query.pb.gois excluded by!**/*.pb.gox/consensus/types/tx.pb.gois excluded by!**/*.pb.gox/staking/types/staking.pb.gois excluded by!**/*.pb.go
Files selected for processing (4)
- api/cosmos/consensus/v1/query.pulsar.go (2 hunks)
- api/cosmos/consensus/v1/tx.pulsar.go (2 hunks)
- depinject/internal/appconfig/buf.gen.pulsar.yaml (1 hunks)
- depinject/internal/appconfig/testpb/test.pulsar.go (2 hunks)
Additional context used
Path-based instructions (3)
api/cosmos/consensus/v1/query.pulsar.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.api/cosmos/consensus/v1/tx.pulsar.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.depinject/internal/appconfig/testpb/test.pulsar.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (6)
depinject/internal/appconfig/buf.gen.pulsar.yaml (1)
2-5: Ensure compatibility with Go package prefix.The
managedsection has been added withenabled: trueand a defaultgo_package_prefix. Verify that this prefix aligns with the project's package structure and does not conflict with existing packages.api/cosmos/consensus/v1/query.pulsar.go (1)
Line range hint
15-17: Verify removal of initialization call.The call to
file_cosmos_consensus_v1_consensus_proto_init()has been removed fromfile_cosmos_consensus_v1_query_proto_init(). Ensure that this change does not affect the initialization of dependencies and that the removed function is no longer required.api/cosmos/consensus/v1/tx.pulsar.go (2)
3-3: Verify impact of import statement removal.The import statement for the CometBFT ABCI protocol buffer has been removed. Ensure that this does not affect any dependencies or functionality that rely on this import.
1416-1474: Review byte array restructuring for readability.The byte array representing the raw descriptor has been restructured. Verify that the changes improve readability and maintain the same functionality.
depinject/internal/appconfig/testpb/test.pulsar.go (2)
5-5: Verify the new import path.The import path has been updated. Ensure that
cosmossdk.io/api/cosmos/app/v1alpha1is the correct and intended path for the dependencies used in this file.
2347-2354: Verify protocol buffer definition changes.The byte array content has changed, indicating updates to the protocol buffer definitions. Ensure that these changes are intentional and that they maintain compatibility with the existing system.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (7)
depinject/internal/appconfig/buf.lockis excluded by!**/*.lockdepinject/internal/appconfiggogo/buf.lockis excluded by!**/*.lockdepinject/internal/appconfiggogo/testpb/test.pb.gois excluded by!**/*.pb.gotestutil/x/counter/types/module.pb.gois excluded by!**/*.pb.gox/consensus/types/query.pb.gois excluded by!**/*.pb.gox/consensus/types/tx.pb.gois excluded by!**/*.pb.gox/staking/types/staking.pb.gois excluded by!**/*.pb.go
Files selected for processing (4)
- api/cosmos/consensus/v1/query.pulsar.go (2 hunks)
- api/cosmos/consensus/v1/tx.pulsar.go (2 hunks)
- depinject/internal/appconfig/buf.gen.pulsar.yaml (1 hunks)
- depinject/internal/appconfig/testpb/test.pulsar.go (2 hunks)
Additional context used
Path-based instructions (3)
api/cosmos/consensus/v1/query.pulsar.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.api/cosmos/consensus/v1/tx.pulsar.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.depinject/internal/appconfig/testpb/test.pulsar.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (3)
depinject/internal/appconfig/buf.gen.pulsar.yaml (1)
2-5: Configuration changes approved.The addition of the
managedsection withenabled: trueandgo_package_prefix: default: cosmossdk.io/apiis correct. This change enhances the configuration by enabling management features and specifying a default package prefix for Go, improving integration and organization.depinject/internal/appconfig/testpb/test.pulsar.go (2)
5-5: Verify the correctness of the new import path.The import path has been updated to
cosmossdk.io/api/cosmos/app/v1alpha1. Ensure that this path is correct and aligns with the intended API structure or versioning strategy.Run the following script to check for the existence of the new import path:
Verification successful
Import path verified successfully.
The new import path
cosmossdk.io/api/cosmos/app/v1alpha1is present in multiple files across the codebase, indicating it is correctly integrated and aligns with the intended API structure or versioning strategy.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the new import path in the codebase. # Test: Search for the new import path. Expect: At least one occurrence. rg --type go 'cosmossdk.io/api/cosmos/app/v1alpha1'Length of output: 3119
2347-2354: Verify the impact of raw descriptor byte array changes.The raw descriptor byte array has been updated. Ensure that these changes do not negatively impact serialization and deserialization processes.
Run the following script to check for any references to
file_testpb_test_proto_rawDescand ensure compatibility:
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (3)
depinject/go.sumis excluded by!**/*.sumdepinject/internal/appconfiggogo/testpb/test.pb.gois excluded by!**/*.pb.gotestutil/x/counter/types/module.pb.gois excluded by!**/*.pb.go
Files selected for processing (3)
- depinject/go.mod (1 hunks)
- depinject/internal/appconfiggogo/buf.gen.gogo.yaml (1 hunks)
- testutil/x/counter/proto/buf.gen.gogo.yaml (1 hunks)
Additional comments not posted (3)
depinject/internal/appconfiggogo/buf.gen.gogo.yaml (1)
5-5: Configuration enhancement approved.The addition of the mapping for
Mcosmos/app/v1alpha1/module.prototocosmossdk.io/api/cosmos/app/v1alpha1in theoptparameter enhances the plugin's functionality.testutil/x/counter/proto/buf.gen.gogo.yaml (1)
5-5: Configuration enhancement approved.The addition of the mapping for
Mcosmos/app/v1alpha1/module.prototocosmossdk.io/api/cosmos/app/v1alpha1in theoptparameter enhances the plugin's functionality.depinject/go.mod (1)
6-6: Dependency addition approved.The addition of the
cosmossdk.io/api v0.7.5dependency enhances the module's capabilities by incorporating additional functionalities or types.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (3)
depinject/go.sumis excluded by!**/*.sumdepinject/internal/appconfiggogo/testpb/test.pb.gois excluded by!**/*.pb.gotestutil/x/counter/types/module.pb.gois excluded by!**/*.pb.go
Files selected for processing (3)
- depinject/go.mod (1 hunks)
- depinject/internal/appconfiggogo/buf.gen.gogo.yaml (1 hunks)
- testutil/x/counter/proto/buf.gen.gogo.yaml (1 hunks)
Additional comments not posted (3)
depinject/internal/appconfiggogo/buf.gen.gogo.yaml (1)
5-5: Verify the impact of the new path mapping.The addition of the path mapping in the
optfield may affect how thegocosmosplugin processes proto files. Ensure that this change is compatible with existing configurations and does not introduce any unintended side effects.testutil/x/counter/proto/buf.gen.gogo.yaml (1)
5-5: Verify the impact of the new module path.The addition of the module path in the
optfield may affect how thegocosmosplugin interacts with the specified modules. Ensure that this change aligns with project requirements and does not introduce any conflicts.depinject/go.mod (1)
6-6: Verify compatibility of the new dependency.The addition of
cosmossdk.io/api v0.7.5as a dependency may introduce new features or capabilities. Ensure that this dependency is compatible with existing ones and does not cause any version conflicts.
depinject/go.mod
Outdated
| @@ -3,6 +3,7 @@ module cosmossdk.io/depinject | |||
| go 1.20 | |||
|
|
|||
| require ( | |||
| cosmossdk.io/api v0.7.5 | |||
There was a problem hiding this comment.
Depinject shouldn't import api.
There was a problem hiding this comment.
I guess it was because of this:
-- _ "cosmossdk.io/depinject/appconfig/v1alpha1"
++ _ "cosmossdk.io/api/cosmos/app/v1alpha1"Not sure what is going on with these proto things, how they can stop working just like that
There was a problem hiding this comment.
We bumped buf in proto-builder 0.15, so that could be that: contrib/Dockerfile
There was a problem hiding this comment.
I don't know how to fix this, the internal protos are using cosmos.app.v1alpha1.module. EDIT: nvm
There was a problem hiding this comment.
@julienrbrt fixed, pls re-review
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (3)
- depinject/internal/appconfig/buf.gen.pulsar.yaml (1 hunks)
- depinject/internal/appconfig/testpb/test.pulsar.go (1 hunks)
- depinject/internal/appconfiggogo/buf.gen.gogo.yaml (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- depinject/internal/appconfig/buf.gen.pulsar.yaml
- depinject/internal/appconfig/testpb/test.pulsar.go
- depinject/internal/appconfiggogo/buf.gen.gogo.yaml
| @@ -2,7 +2,7 @@ version: v1 | |||
| plugins: | |||
| - name: gocosmos | |||
| out: .. | |||
| opt: plugins=grpc,Mgoogle/protobuf/any.proto=github.com/cosmos/gogoproto/types/any | |||
| opt: plugins=grpc,Mgoogle/protobuf/any.proto=github.com/cosmos/gogoproto/types/any,Mcosmos/app/v1alpha1/module.proto=cosmossdk.io/api/cosmos/app/v1alpha1 | |||
There was a problem hiding this comment.
We may need to backport this PR to 0.52 only for this 😅
|
@Mergifyio backport release/0.52.x |
❌ No backport have been created
GitHub error: |
|
@Mergifyio backport release/v0.52.x |
✅ Backports have been created
|
(cherry picked from commit 7c69f65) # Conflicts: # api/cosmos/consensus/v1/query.pulsar.go # api/cosmos/consensus/v1/tx.pulsar.go # depinject/internal/appconfig/buf.gen.pulsar.yaml # depinject/internal/appconfig/testpb/test.pulsar.go # depinject/internal/appconfiggogo/buf.gen.gogo.yaml
Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Documentation