feat(server/v2): add min gas price and check with tx fee #21173
Conversation
github-actions
bot
added
C:Confix
WalkthroughWalkthroughThe recent changes enhance transaction processing within the CometBFT application by implementing minimum gas price requirements. Key updates include a new method for validating transaction fees, improved error handling for fee-related issues, and refinements to configuration management. These modifications ensure that transactions are economically viable according to validator settings. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Server
participant Config
participant Validator
User->>Server: Start server with configuration
Server->>Config: Validate server configuration
Config-->>Server: Return validation result
alt Configuration valid
Server->>Validator: Process transaction with minimum gas prices
Validator-->>Server: Confirm transaction
else Configuration invalid
Server-->>User: Error message
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
|
@akhilkumarpilli your pull request is missing a changelog! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (10)
- server/v2/cometbft/abci.go (4 hunks)
- server/v2/cometbft/config.go (3 hunks)
- server/v2/cometbft/flags.go (1 hunks)
- server/v2/cometbft/go.mod (2 hunks)
- server/v2/cometbft/server.go (2 hunks)
- server/v2/cometbft/types/errors/errors.go (1 hunks)
- simapp/v2/simdv2/cmd/commands.go (1 hunks)
- simapp/v2/simdv2/cmd/testnet.go (1 hunks)
- tools/confix/data/v2-app.toml (1 hunks)
- tools/confix/migrations.go (1 hunks)
Additional context used
Path-based instructions (8)
server/v2/cometbft/types/errors/errors.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.server/v2/cometbft/flags.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.server/v2/cometbft/config.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.simapp/v2/simdv2/cmd/commands.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.tools/confix/migrations.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.server/v2/cometbft/server.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.simapp/v2/simdv2/cmd/testnet.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.server/v2/cometbft/abci.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (20)
server/v2/cometbft/types/errors/errors.go (3)
18-19: LGTM!The error constant
ErrTxDecodeis correctly defined and follows the existing pattern in the file.
21-22: LGTM!The error constant
ErrInsufficientFeeis correctly defined and follows the existing pattern in the file.
24-25: LGTM!The error constant
ErrAppConfigis correctly defined and follows the existing pattern in the file.server/v2/cometbft/flags.go (1)
60-60: LGTM!The server flag
FlagMinGasPricesis correctly defined and follows the existing pattern in the file.tools/confix/data/v2-app.toml (1)
2-3: LGTM!The configuration parameter
minimum-gas-pricesis correctly defined with a default value and a comment explaining its purpose.server/v2/cometbft/config.go (3)
4-11: Imports look good.The new imports
fmtandcometerrorsare necessary and correctly used in the file.
34-34: Field definition and documentation look good.The new field
MinGasPricesis correctly defined and well-documented in theAppTomlConfigstruct.
88-95: Validation logic looks good.The
ValidateBasicmethod correctly checks for theMinGasPricesfield and provides a meaningful error message.simapp/v2/simdv2/cmd/commands.go (1)
73-99: Configuration implementation looks good.The new configuration for
cometAppTomlCfgwithMinGasPricesset to "0stake" is correctly implemented and well-documented.tools/confix/migrations.go (1)
38-39: Key-value pair definition looks good.The new key-value pair for
"minimum-gas-prices"is correctly defined and integrated into thev2KeyChangesvariable.server/v2/cometbft/server.go (2)
226-226: LGTM! The new flag enhances configurability.The addition of the
FlagMinGasPricesflag is a valuable enhancement.
133-136: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
Startcorrectly handle the new validation step.Verification successful
LGTM! The function usage correctly handles the new validation step.
The code changes are approved.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `Start` handle the new validation step. # Test: Search for the function usage. Expect: Proper error handling for the validation step. rg --type go -A 5 $'Start(ctx context.Context)'Length of output: 48
Script:
#!/bin/bash # Description: Verify all function calls to `Start` handle the new validation step. # Test: Search for all function usages of `Start`. Expect: Proper error handling for the validation step. rg --type go -A 5 'Start('Length of output: 91
Script:
#!/bin/bash # Description: Verify all function calls to `Start` handle the new validation step. # Test: Search for all function usages of `Start`. Expect: Proper error handling for the validation step. rg --type go -A 5 'Start\('Length of output: 22166
server/v2/cometbft/go.mod (1)
28-28: LGTM! The dependency change is appropriate.The addition of
cosmossdk.io/math v1.3.0as a direct dependency is appropriate and suggests a refinement in dependency management.simapp/v2/simdv2/cmd/testnet.go (2)
340-342: LGTM! The configuration enhancement is valuable.The addition of
cometAppTomlCfgand updates to thecometbft.Newfunction call enhance the configuration capabilities of theinitTestnetFilesfunction.
348-348: LGTM! The integration of the modified configuration is appropriate.The integration of
cometAppTomlCfginto thecometbft.Newfunction call is appropriate and enhances the server's initialization process.server/v2/cometbft/abci.go (5)
21-21: New import statement looks good.The import of
sdkmathis necessary for the mathematical operations related to gas calculations.
158-188: New method implementation looks good with a minor improvement suggestion.The
checkTxFeeWithMinGasPricesmethod correctly ensures that provided fees meet a minimum threshold. Error handling is appropriately managed.Minor improvement suggestion:
- Consider adding a comment to explain the purpose of the
sdkmath.LegacyNewDecfunction for better readability.
Line range hint
1-1: File conforms to the Uber Golang style guide.The file follows the Uber Golang style guide, with clear and concise function implementations, appropriate error handling, and consistent naming conventions.
Also applies to: 31-31, 128-188
Line range hint
1-1: File review complete. No issues or improvements identified.The file is well-structured and follows best practices.
Also applies to: 31-31, 128-188
128-134: LGTM! Ensure the function usage is verified.The added validation step in
CheckTxensures transactions meet the minimum gas price requirements. Error handling is appropriately managed.However, ensure that all function calls to
CheckTxare correctly updated.Verification successful
LGTM! Ensure the function usage is verified.
The added validation step in
CheckTxensures transactions meet the minimum gas price requirements. Error handling is appropriately managed.However, ensure that all function calls to
CheckTxare correctly updated. Based on the search results, the function calls appear to be correctly updated.
- Verify that
checkTxFeeWithMinGasPricesis being used correctly in theCheckTxmethod.- Ensure that all relevant test cases cover the new validation logic.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `CheckTx` are correctly updated. # Test: Search for the function usage. Expect: Only occurrences of the updated function. rg --type go -A 5 $'CheckTx'Length of output: 43976
server/v2/cometbft/config.go
Outdated
| // GetMinGasPrices returns the validator's minimum gas prices based on the set configuration. | ||
| func (c Config) GetMinGasPrices() sdk.DecCoins { | ||
| minGasPricesStr := c.AppTomlConfig.MinGasPrices | ||
| if minGasPricesStr == "" { | ||
| return sdk.DecCoins{} | ||
| } | ||
|
|
||
| gasPrices, err := sdk.ParseDecCoins(minGasPricesStr) | ||
| if err != nil { | ||
| panic(fmt.Sprintf("invalid minimum gas prices: %v", err)) | ||
| } | ||
|
|
||
| return gasPrices | ||
| } |
There was a problem hiding this comment.
Ensure proper error handling in GetMinGasPrices.
The GetMinGasPrices method is well-implemented, but consider handling errors more gracefully rather than panicking.
- panic(fmt.Sprintf("invalid minimum gas prices: %v", err))
+ return sdk.DecCoins{}, fmt.Errorf("invalid minimum gas prices: %v", err)Committable suggestion was skipped due to low confidence.
server/v2/cometbft/abci.go
Outdated
| func (c *Consensus[T]) checkTxFeeWithMinGasPrices(tx transaction.Tx) error { | ||
| feeTx, ok := tx.(sdk.FeeTx) | ||
| if !ok { | ||
| return errorsmod.Wrap(cometerrors.ErrTxDecode, "tx must be a feeTx") |
There was a problem hiding this comment.
We should avoid the error here. Forcing users that don't use our tx to implement an interface specific to our implementation seems like a code smell
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
server/v2/cometbft/abci.go (1)
128-134: Ensure proper error handling and logging.The new validation step in
CheckTxmethod correctly checks the transaction fees against the minimum gas price. However, it would be beneficial to include more detailed logging for better traceability.- return &abciproto.CheckTxResponse{ + c.logger.Error("Transaction fee validation failed", "error", err) + return &abciproto.CheckTxResponse{
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- server/v2/cometbft/abci.go (4 hunks)
- server/v2/cometbft/go.mod (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- server/v2/cometbft/go.mod
Additional context used
Path-based instructions (1)
server/v2/cometbft/abci.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (3)
server/v2/cometbft/abci.go (3)
128-134: Ensure correct error handling inCheckTx.The error handling for the
checkTxFeeWithMinGasPricescall is appropriate, but consider logging the error for better traceability.+ c.logger.Error("tx fee validation failed", "err", err)
158-160: Clarify the method's scope and usage in the comment.The comment should explicitly mention that this method is intended for use in
CheckTxonly and is not meant for other types of transactions.// checkTxFeeWithMinGasPrices ensures that the provided fees meet a minimum threshold for the validator, // if this is a CheckTx. This is only for local mempool purposes, and thus // is only run on check tx.
175-183: Optimize fee calculation loop.The fee calculation loop is correctly implemented, but consider adding a comment explaining the logic for better readability.
// Determine the required fees by multiplying each required minimum gas // price by the gas limit, where fee = ceil(minGasPrice * gasLimit).
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- server/v2/cometbft/abci.go (4 hunks)
Additional context used
Path-based instructions (1)
server/v2/cometbft/abci.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (3)
server/v2/cometbft/abci.go (3)
162-164: Avoid forcing users to implement specific interfaces.The current implementation correctly avoids forcing users to implement the
sdk.FeeTxinterface. This is a good practice to maintain flexibility.
170-173: Optimize early return for zero minimum gas prices.The early return for zero minimum gas prices is correctly implemented, ensuring that unnecessary computations are avoided.
185-187: Ensure detailed error messages for insufficient fees.The error message for insufficient fees is detailed and informative, which is good for debugging and user feedback.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (4)
- server/v2/config.go (1 hunks)
- server/v2/flags.go (1 hunks)
- server/v2/server.go (6 hunks)
- simapp/v2/simdv2/cmd/testnet.go (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- simapp/v2/simdv2/cmd/testnet.go
Additional context used
Path-based instructions (3)
server/v2/flags.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.server/v2/config.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.server/v2/server.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (11)
server/v2/flags.go (2)
9-11: LGTM!The
prefixfunction is correctly implemented to concatenate the server name with a given flag name.
13-13: LGTM!The
FlagMinGasPricesvariable is correctly defined using theprefixfunction.server/v2/config.go (4)
11-13: LGTM!The
ServerConfigstruct is correctly defined with theMinGasPricesfield and appropriate annotations.
16-22: LGTM!The
ValidateBasicmethod correctly implements basic validation for theMinGasPricesfield.
25-27: LGTM!The
DefaultMainServerConfigfunction correctly initializes and returns a defaultServerConfiginstance.
30-32: LGTM!The
OverwriteDefaultConfigmethod correctly updates the server's configuration with the providedServerConfiginstance.server/v2/server.go (5)
60-60: LGTM!The
serverNameconstant is correctly defined to standardize the server name.
67-68: LGTM!The addition of the
configfield to theServerstruct enhances its configuration management.
87-91: LGTM!The validation step in the
Startmethod ensures the server does not start with an invalid configuration, enhancing robustness.
165-167: LGTM!The
Configmethod correctly provides access to the server's configuration.
187-191: LGTM!The
StartCmdFlagsmethod correctly facilitates the creation of command-line flags specific to the server.
julienrbrt
added
the
backport/v0.52.x
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- tests/systemtests/staking_test.go (1 hunks)
- x/auth/ante/fee.go (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- x/auth/ante/fee.go
Additional context used
Path-based instructions (1)
tests/systemtests/staking_test.go (3)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
Additional comments not posted (1)
tests/systemtests/staking_test.go (1)
Line range hint
1-1: LGTM! Ensure comprehensive test coverage.The removal of the skip line indicates that the test is now relevant for execution. The function appears to be well-structured and covers the key aspects of staking and unstaking. However, ensure that the test covers all edge cases and handles potential errors.
The code changes are approved.
Run the following script to verify the test coverage:
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range, codebase verification and nitpick comments (3)
x/auth/tx/config/depinject.go (1)
116-144: Function Implementation Approved with SuggestionsThe
ProvideModulefunction correctly sets up the module configurations and validators, including the new minimum gas prices feature. Consider adding more detailed error logging around the minimum gas prices parsing to aid in debugging potential configuration issues in production environments.simapp/v2/simdv2/cmd/testnet.go (2)
131-131: Function Modification Approved with SuggestionsThe update to retrieve minimum gas prices using
serverv2.FlagMinGasPricesintestnetInitFilesCmdfunction is correctly implemented. Consider adding validation for the retrieved gas prices to ensure they are within expected ranges and formats to prevent runtime issues.
Line range hint
339-350: Function Modification Approved with SuggestionsThe integration of minimum gas prices into the server configuration in
initTestnetFilesfunction is well-implemented. Recommend thorough testing to ensure that the configuration behaves as expected under various network conditions and transaction volumes.
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (8)
- server/v2/server_test.go (1 hunks)
- simapp/v2/simdv2/cmd/commands.go (1 hunks)
- simapp/v2/simdv2/cmd/config.go (2 hunks)
- simapp/v2/simdv2/cmd/testnet.go (5 hunks)
- x/auth/ante/fee.go (5 hunks)
- x/auth/ante/validator_tx_fee.go (3 hunks)
- x/auth/tx/config/depinject.go (5 hunks)
- x/auth/tx/config/module.go (2 hunks)
Files skipped from review as they are similar to previous changes (3)
- server/v2/server_test.go
- simapp/v2/simdv2/cmd/commands.go
- x/auth/ante/fee.go
Additional context used
Path-based instructions (5)
x/auth/tx/config/module.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/auth/ante/validator_tx_fee.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.simapp/v2/simdv2/cmd/config.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/auth/tx/config/depinject.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.simapp/v2/simdv2/cmd/testnet.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (5)
x/auth/tx/config/module.go (1)
22-22: Addition offeeTxValidatorfield toAppModulestruct is well-placed.This new field aligns with the PR's objective to enhance transaction fee validation capabilities.
x/auth/ante/validator_tx_fee.go (1)
17-17: Refactoring ofcheckTxFeeWithValidatorMinGasPricesenhances functionality.The method now properly utilizes the
DeductFeeDecorator's state and methods, improving context-awareness and integration. The shift tocontext.Contextis a positive change towards standardizing context handling in Go.Also applies to: 29-30
x/auth/tx/config/depinject.go (2)
38-39: Constant Definition ApprovedThe constant
flagMinGasPricesV2is correctly defined and follows Go naming conventions.
57-68: Struct Modification ApprovedThe addition of the
Viperfield inModuleInputsstruct is appropriate for dynamic configuration management. Ensure that theViperinstance is properly initialized and used wherever necessary to avoid runtime panics.simapp/v2/simdv2/cmd/testnet.go (1)
74-74: Function Modification ApprovedThe update to use
serverv2.FlagMinGasPricesinaddTestnetFlagsToCmdfunction enhances consistency in flag management. Ensure that all references to the old flag are updated across the entire codebase to avoid configuration errors.
| @@ -28,6 +29,7 @@ type AppModule struct { | |||
| // NewAppModule creates a new AppModule object. | |||
| func NewAppModule( | |||
| sigVerification ante.SigVerificationDecorator, | |||
| feeTxValidator *ante.DeductFeeDecorator, | |||
There was a problem hiding this comment.
Constructor does not initialize feeTxValidator.
The feeTxValidator parameter is accepted in the constructor but is not assigned to the AppModule struct. This looks like an oversight.
Consider adding the following line in the constructor to fix this issue:
+ feeTxValidator: feeTxValidator,Also applies to: 40-40
| func initServerConfig() serverv2.ServerConfig { | ||
| serverCfg := serverv2.DefaultServerConfig() | ||
| // The server's default minimum gas price is set to "0stake" inside | ||
| // app.toml. However, the chain developer can set a default app.toml value for their | ||
| // validators here. Please update value based on chain denom. | ||
| // | ||
| // In summary: | ||
| // - if you set serverCfg.MinGasPrices value, validators CAN tweak their | ||
| // own app.toml to override, or use this default value. | ||
| // | ||
| // In simapp, we set the min gas prices to 0. | ||
| serverCfg.MinGasPrices = "0stake" | ||
|
|
||
| return serverCfg | ||
| } |
There was a problem hiding this comment.
Addition of initServerConfig function enhances configurability.
The function allows chain developers to set a default MinGasPrices value, enhancing flexibility. However, consider making the MinGasPrices value configurable to accommodate different chain denominations more effectively.
Consider adding a parameter to the initServerConfig function to allow passing the default MinGasPrices value, making it more adaptable to different chains.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- x/auth/tx/config/module.go (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- x/auth/tx/config/module.go
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (3)
- x/auth/ante/fee.go (5 hunks)
- x/auth/ante/validator_tx_fee.go (3 hunks)
- x/auth/tx/config/module.go (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- x/auth/tx/config/module.go
Additional context used
Path-based instructions (2)
x/auth/ante/validator_tx_fee.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/auth/ante/fee.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (12)
x/auth/ante/validator_tx_fee.go (4)
4-7: LGTM!The new imports are necessary for the changes made in the file.
The code changes are approved.
Line range hint
17-29: LGTM!The changes enhance the method's integration with the surrounding architecture, allowing for more flexible and context-aware fee validation logic.
The code changes are approved.
Line range hint
29-36: LGTM!The changes improve the fee validation logic by integrating it with the
DeductFeeDecoratorstruct.The code changes are approved.
Line range hint
38-54: LGTM!The function is correctly implemented and does not require any changes.
The code changes are approved.
x/auth/ante/fee.go (8)
5-8: LGTM!The new imports are necessary for the changes made in the file.
The code changes are approved.
19-19: LGTM!The change enhances the flexibility of the context being used, allowing for better integration with standard Go context handling.
The code changes are approved.
30-30: LGTM!The addition of the
minGasPricesfield improves the state management of the decorator.The code changes are approved.
33-46: LGTM!The change ensures that the state is maintained correctly across invocations.
The code changes are approved.
49-52: LGTM!The function is correctly implemented and does not require any changes.
The code changes are approved.
54-64: LGTM!The changes improve the modularity and clarity of the fee deduction logic.
The code changes are approved.
66-91: LGTM!The function is correctly implemented and does not require any changes.
The code changes are approved.
Line range hint
101-145: LGTM!The changes simplify the logic for fee deduction and ensure that the correct accounts are used for fee processing.
The code changes are approved.
Co-authored-by: Julien Robert <[email protected]> (cherry picked from commit 81a225e) # Conflicts: # server/v2/commands.go # server/v2/config.go # server/v2/flags.go # server/v2/server.go # server/v2/server_test.go # server/v2/testdata/app.toml
…1173) (#21453) Co-authored-by: Akhil Kumar P <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Description
Closes: #XXXX
minimum-gas-pricesconfig in server configminimum-gas-pricesvalue in x/auth/txTxValidatormethod.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Chores