Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serverv2): integrate gRPC (backport #21038) #21132

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 31, 2024

Description

This PR Integrates gRPC in serverv2 leveraging grpc.UnknownServiceHandler to provide mapping between grpc methods and an appmanager query call.

closes: #20798


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Enhanced gRPC method handling with a new mapping method for simplified message generation.
    • Improved logging and service management for the server reflection functionality.
    • Introduction of new constants for managing gRPC metadata.
  • Bug Fixes

    • Streamlined handling of unknown gRPC services and improved error handling.
  • Refactor

    • Renamed and updated methods and structures for clarity and consistency.
    • Simplified the decoding process by eliminating the need for input parameters in gRPC method functions.
  • Chores

    • Updated dependency management for better control and clarity on required packages.

This is an automatic backport of pull request #21038 done by [Mergify](https://mergify.com).

Co-authored-by: Marko <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
(cherry picked from commit 8b47141)

# Conflicts:
#	schema/appdata/mux_test.go
#	server/v2/cometbft/server.go
#	server/v2/go.mod
@mergify mergify bot requested a review from a team as a code owner July 31, 2024 21:12
@mergify mergify bot added the conflicts label Jul 31, 2024
Copy link
Contributor Author

mergify bot commented Jul 31, 2024

Cherry-pick of 8b47141 has failed:

On branch mergify/bp/release/v0.52.x/pr-21038
Your branch is up to date with 'origin/release/v0.52.x'.

You are currently cherry-picking commit 8b4714165.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   runtime/v2/app.go
	modified:   runtime/v2/manager.go
	modified:   runtime/v2/module.go
	modified:   server/v2/api/grpc/gogoreflection/serverreflection.go
	modified:   server/v2/api/grpc/server.go
	modified:   server/v2/cometbft/abci.go
	modified:   server/v2/server_test.go
	modified:   server/v2/types.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   schema/appdata/mux_test.go
	both modified:   server/v2/cometbft/server.go
	both modified:   server/v2/go.mod

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Jul 31, 2024
12 tasks
Copy link
Contributor

coderabbitai bot commented Jul 31, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@mergify[bot] your pull request is missing a changelog!

@github-actions github-actions bot removed the C:schema label Jul 31, 2024
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Things will be synced properly after #21093

@julienrbrt julienrbrt merged commit 0ca08e1 into release/v0.52.x Jul 31, 2024
67 of 68 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.52.x/pr-21038 branch July 31, 2024 21:21
Comment on lines +571 to +573
for path, decoder := range c.grpcQueryDecoders {
app.GRPCMethodsToMessageMap[path] = decoder
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants