Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(serverv2): integrate gRPC #21038
feat(serverv2): integrate gRPC #21038
Changes from 9 commits
3c0ddc0
9162065
cdbd164
8ab8b26
a83f470
7b3e051
0a5e2ae
422ea8d
9308ae7
1e612d1
9839aea
1fc2735
02d7289
d6f6d7d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning
Code scanning / CodeQL
Iteration over map Warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve error handling and optimize
getServices
method.The
getServices
method is well-structured but can be improved by handling errors more effectively and optimizing the conversion of method names.Additionally, consider logging the successful retrieval of method descriptors for better traceability.
+ s.log.Info("successfully retrieved method descriptor", "method", methodName)