Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove inaccurate statement about PoW chains #20877

Merged
merged 4 commits into from
Jul 5, 2024
Merged

docs: remove inaccurate statement about PoW chains #20877

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b06cb5
chore: remove inaccurate statement about PoW chains
0xkrane Jul 4, 2024
8592424
Merge branch 'main' into 0xkrane-patch-2
0xkrane Jul 4, 2024
92b2725
Merge branch 'main' into 0xkrane-patch-2
0xkrane Jul 4, 2024
e6a421a
Merge branch 'main' into 0xkrane-patch-2
tac0turtle Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/learn/intro/01-why-app-specific.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ The list above contains a few examples that show how much flexibility applicatio

Decentralized applications built with Smart Contracts are inherently capped in performance by the underlying environment. For a decentralized application to optimise performance, it needs to be built as an application-specific blockchain. Next are some of the benefits an application-specific blockchain brings in terms of performance:

* Developers of application-specific blockchains can choose to operate with a novel consensus engine such as CometBFT. Compared to Proof-of-Work (used by most virtual-machine blockchains today), it offers significant gains in throughput.
* Developers of application-specific blockchains can choose to operate with a novel consensus engine such as CometBFT.
* An application-specific blockchain only operates a single application, so that the application does not compete with others for computation and storage. This is the opposite of most non-sharded virtual-machine blockchains today, where smart contracts all compete for computation and storage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary comma.

The conjunction “so that” does not require a comma.

- an application-specific blockchain only operates a single application, so that the application does not compete with others for computation and storage.
+ an application-specific blockchain only operates a single application so that the application does not compete with others for computation and storage.
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* An application-specific blockchain only operates a single application, so that the application does not compete with others for computation and storage. This is the opposite of most non-sharded virtual-machine blockchains today, where smart contracts all compete for computation and storage.
* An application-specific blockchain only operates a single application so that the application does not compete with others for computation and storage. This is the opposite of most non-sharded virtual-machine blockchains today, where smart contracts all compete for computation and storage.
Tools
LanguageTool

[typographical] ~72-~72: The conjunction “so that” does not require a comma.
Context: ...chain only operates a single application, so that the application does not compete with o...

(SO_THAT_UNNECESSARY_COMMA)

* Even if a virtual-machine blockchain offered application-based sharding coupled with an efficient consensus algorithm, performance would still be limited by the virtual-machine itself. The real throughput bottleneck is the state-machine, and requiring transactions to be interpreted by a virtual-machine significantly increases the computational complexity of processing them.

Expand Down
Loading