Fix-up store #206
Merged
Fix-up store #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudhead
approved these changes
Aug 3, 2017
yihuang
added a commit
to yihuang/cosmos-sdk
that referenced
this pull request
Mar 27, 2024
generic interface generic btree generic cachekv generic transient store support ObjStore changelog Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> object store key Apply review suggestions fix merge conflict fix snapshot revert dependers
dudong2
referenced
this pull request
in b-harvest/cosmos-sdk
Oct 17, 2024
generic interface generic btree generic cachekv generic transient store support ObjStore changelog Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> object store key Apply review suggestions fix merge conflict fix snapshot revert dependers
dudong2
referenced
this pull request
in b-harvest/cosmos-sdk
Oct 17, 2024
generic interface generic btree generic cachekv generic transient store support ObjStore changelog Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> object store key Apply review suggestions fix merge conflict fix snapshot revert dependers
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this pull request
Dec 12, 2024
generic interface generic btree generic cachekv generic transient store support ObjStore changelog Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> object store key Apply review suggestions fix merge conflict fix snapshot revert dependers
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this pull request
Dec 12, 2024
generic interface generic btree generic cachekv generic transient store support ObjStore changelog Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> object store key Apply review suggestions fix merge conflict fix snapshot revert dependers
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this pull request
Dec 16, 2024
generic interface generic btree generic cachekv generic transient store support ObjStore changelog Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> object store key Apply review suggestions fix merge conflict fix snapshot revert dependers
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this pull request
Dec 16, 2024
generic interface generic btree generic cachekv generic transient store support ObjStore changelog Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> object store key Apply review suggestions fix merge conflict fix snapshot revert dependers
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this pull request
Dec 16, 2024
generic interface generic btree generic cachekv generic transient store support ObjStore changelog Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> object store key Apply review suggestions fix merge conflict fix snapshot revert dependers Problem: store key type assertion is incorrect (cosmos#244) fix and add test
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this pull request
Dec 16, 2024
generic interface generic btree generic cachekv generic transient store support ObjStore changelog Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> object store key Apply review suggestions fix merge conflict fix snapshot revert dependers Problem: store key type assertion is incorrect (cosmos#244) fix and add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized in the store overhaul, that KVCache no longer syncs in a deterministic order (as I had hoped not to need it for the merkle Tree). That means that in multiple node setups, one would soon have consensus failure as the AppHash would diverge even for the same contents. (But not in the one-node unit tests...)
Added a test case to ensure that applying changes to DeliverTx and then Committing them produces a deterministic hash, and now order the key sync properly.