fix: fix marshaling for appgenesis #20597

matthiasmatt · 2024-06-07T15:54:15Z

Description

Closes: #20596

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

Bug Fixes
- Improved the marshalling service in the genutil module to enhance data handling and storage.

coderabbitai · 2024-06-07T15:54:24Z

Walkthrough

The change addresses a bug in the genutil module of the cosmos-sdk project. Specifically, the SaveAs method in the AppGenesis struct was updated to use cmtjson.MarshalIndent instead of json.MarshalIndent. This ensures compatibility with CometBFT's unmarshalling expectations, which require certain integers to be encoded as strings.

Changes

File	Change Summary
`CHANGELOG.md`	Added an entry for the fix in the `genutil` module to use `cmtjson.MarshalIndent` for marshalling.
`x/genutil/types/genesis.go`	Updated the `SaveAs` method in `AppGenesis` struct to use `cmtjson.MarshalIndent` instead of `json.MarshalIndent`.

Sequence Diagram(s) (Beta)

No diagrams generated as the changes are straightforward and do not significantly alter the control flow.

Assessment against linked issues

Objective	Addressed	Explanation
Fix the marshalling in `SaveAs` method to ensure compatibility with CometBFT's unmarshalling (20596)	✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ca14b28 and 5371705.

Files selected for processing (2)

CHANGELOG.md (1 hunks)
x/genutil/types/genesis.go (1 hunks)

Additional context used

Path-based instructions (2)

x/genutil/types/genesis.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

Markdownlint

CHANGELOG.md

70-70: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

71-71: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

75-75: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

76-76: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

77-77: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

78-78: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

83-83: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

128-128: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

129-129: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

130-130: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

134-134: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

137-137: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

138-138: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

139-139: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

146-146: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

156-156: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

158-158: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

161-161: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

180-180: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

181-181: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

183-183: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

184-184: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

216-216: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

217-217: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

218-218: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

382-382: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

385-385: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

407-407: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

408-408: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

421-421: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

453-453: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

454-454: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

455-455: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

456-456: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

458-458: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

459-459: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

460-460: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

461-461: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

475-475: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

477-477: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

479-479: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

481-481: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

484-484: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

485-485: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

486-486: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

494-494: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

495-495: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

497-497: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

498-498: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

500-500: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

501-501: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

502-502: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

504-504: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

505-505: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

513-513: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

524-524: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

525-525: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

526-526: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

532-532: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

533-533: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

534-534: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

540-540: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

556-556: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

557-557: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

558-558: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

559-559: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

560-560: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

561-561: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

566-566: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

567-567: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

568-568: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

569-569: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

576-576: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

577-577: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

578-578: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

612-612: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

613-613: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

614-614: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

615-615: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

620-620: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

621-621: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

758-758: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

901-901: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

922-922: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

925-925: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1007-1007: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1008-1008: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1009-1009: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1010-1010: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1011-1011: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1012-1012: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1109-1109: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1195-1195: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1241-1241: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1247-1247: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1248-1248: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1249-1249: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1250-1250: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1251-1251: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1252-1252: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1352-1352: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1477-1477: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1478-1478: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1479-1479: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1480-1480: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1481-1481: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1482-1482: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1483-1483: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1484-1484: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1487-1487: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1488-1488: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1489-1489: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1490-1490: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1491-1491: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1492-1492: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1741-1741: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1742-1742: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1743-1743: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1744-1744: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1745-1745: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1746-1746: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1856-1856: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2193-2193: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2194-2194: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2195-2195: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2198-2198: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2199-2199: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2200-2200: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2222-2222: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2223-2223: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2224-2224: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2225-2225: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2226-2226: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2234-2234: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2235-2235: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2236-2236: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2237-2237: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2238-2238: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2240-2240: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2241-2241: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2242-2242: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2569-2569: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2570-2570: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2571-2571: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2572-2572: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2573-2573: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2575-2575: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2577-2577: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2578-2578: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2579-2579: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2580-2580: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2581-2581: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2582-2582: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2584-2584: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2585-2585: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2586-2586: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2589-2589: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2590-2590: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2591-2591: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2592-2592: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2593-2593: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2596-2596: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2599-2599: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2602-2602: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2603-2603: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2606-2606: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2613-2613: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2614-2614: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2615-2615: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2616-2616: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2617-2617: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2619-2619: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2620-2620: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2621-2621: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2622-2622: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2623-2623: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2624-2624: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2625-2625: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2626-2626: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2627-2627: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2630-2630: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2631-2631: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2632-2632: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2633-2633: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2634-2634: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2635-2635: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2642-2642: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2643-2643: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2644-2644: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2645-2645: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2652-2652: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2654-2654: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2656-2656: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2657-2657: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2658-2658: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2659-2659: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2660-2660: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2661-2661: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2662-2662: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2663-2663: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2664-2664: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2665-2665: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2666-2666: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2667-2667: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2668-2668: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2669-2669: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2670-2670: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2671-2671: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2672-2672: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2673-2673: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2674-2674: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2675-2675: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2676-2676: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2677-2677: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2678-2678: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2679-2679: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2680-2680: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2681-2681: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2682-2682: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2684-2684: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2685-2685: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2687-2687: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2688-2688: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2689-2689: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2690-2690: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2691-2691: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2692-2692: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2693-2693: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2696-2696: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2697-2697: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2699-2699: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2700-2700: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2703-2703: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2704-2704: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2705-2705: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2706-2706: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2707-2707: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2708-2708: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2709-2709: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2710-2710: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2712-2712: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2713-2713: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2714-2714: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2720-2720: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2723-2723: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2729-2729: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2737-2737: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2738-2738: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2739-2739: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2740-2740: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2748-2748: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2755-2755: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2756-2756: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2763-2763: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2765-2765: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2769-2769: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2770-2770: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2772-2772: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2780-2780: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2782-2782: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2783-2783: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2789-2789: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2797-2797: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2798-2798: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2799-2799: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2800-2800: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2801-2801: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2802-2802: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2803-2803: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2804-2804: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2805-2805: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2806-2806: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2807-2807: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2808-2808: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2809-2809: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2810-2810: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2812-2812: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2813-2813: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2815-2815: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2816-2816: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2817-2817: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2818-2818: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2819-2819: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2820-2820: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2821-2821: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2822-2822: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2823-2823: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2824-2824: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2826-2826: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2827-2827: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2830-2830: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2831-2831: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2832-2832: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2833-2833: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2834-2834: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2835-2835: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2836-2836: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2837-2837: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2838-2838: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2839-2839: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2840-2840: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2841-2841: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2842-2842: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2843-2843: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2844-2844: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2845-2845: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2850-2850: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2851-2851: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2852-2852: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2853-2853: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2854-2854: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2855-2855: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2857-2857: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2859-2859: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2873-2873: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2874-2874: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2875-2875: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2880-2880: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2881-2881: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2882-2882: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2886-2886: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2887-2887: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2888-2888: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2889-2889: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2890-2890: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2891-2891: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2894-2894: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2895-2895: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2896-2896: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2897-2897: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2898-2898: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2899-2899: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2900-2900: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2901-2901: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2902-2902: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2904-2904: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2906-2906: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2908-2908: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2913-2913: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2914-2914: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2915-2915: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2916-2916: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2917-2917: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2918-2918: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2919-2919: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2920-2920: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2921-2921: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2922-2922: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2923-2923: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2924-2924: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2925-2925: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2926-2926: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2927-2927: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2928-2928: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2929-2929: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2930-2930: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2931-2931: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2932-2932: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2933-2933: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

190-190: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces

213-213: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces

66-66: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines

67-67: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines

1659-1659: null (MD034, no-bare-urls)
Bare URL used

1689-1689: null (MD034, no-bare-urls)
Bare URL used

2636-2636: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2724-2724: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2726-2726: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2731-2731: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2733-2733: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2743-2743: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2745-2745: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2750-2750: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2758-2758: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2775-2775: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2777-2777: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2785-2785: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2791-2791: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2861-2861: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2864-2864: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2867-2867: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2869-2869: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2909-2909: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

1030-1030: null (MD038, no-space-in-code)
Spaces inside code span elements

2677-2677: null (MD038, no-space-in-code)
Spaces inside code span elements

2677-2677: null (MD038, no-space-in-code)
Spaces inside code span elements

Additional comments not posted (1)

x/genutil/types/genesis.go (1)

82-82: Change from json.MarshalIndent to cmtjson.MarshalIndent correctly addresses the marshaling issue with int64 values.

coderabbitai · 2024-06-07T16:13:05Z

CHANGELOG.md

@@ -116,6 +116,7 @@ Every module contains its own CHANGELOG.md. Please refer to the module you are i
 * [#19851](https://github.com/cosmos/cosmos-sdk/pull/19851) Fix some places in which we call Remove inside a Walk (x/staking and x/gov).
 * (cli) [#20020](https://github.com/cosmos/cosmos-sdk/pull/20020) Make bootstrap-state command support both new and legacy genesis format.
 * (baseapp) [#20107](https://github.com/cosmos/cosmos-sdk/pull/20107) Allow height overwrite BlockHeight in header.
+* (genutil) [#20596](https://github.com/cosmos/cosmos-sdk/pull/20596) Fix marshalling service used.


The changelog entry succinctly captures the essence of the changes made in PR #20596. However, it could be enhanced by specifying that the marshalling change was made to ensure compatibility with CometBFT's expectations, as detailed in the PR description.

- * (genutil) [#20596](https://github.com/cosmos/cosmos-sdk/pull/20596) Fix marshalling service used. + * (genutil) [#20596](https://github.com/cosmos/cosmos-sdk/pull/20596) Update marshalling in `AppGenesis` to use `cmtjson.MarshalIndent`, ensuring compatibility with CometBFT.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

* (genutil) [#20596](https://github.com/cosmos/cosmos-sdk/pull/20596) Fix marshalling service used.

* (genutil) [#20596](https://github.com/cosmos/cosmos-sdk/pull/20596) Update marshalling in `AppGenesis` to use `cmtjson.MarshalIndent`, ensuring compatibility with CometBFT.

tac0turtle · 2024-06-07T17:54:02Z

Commented in the issue. This is not a bug but by design. Thank you for opening a pr

fragwuerdig · 2024-06-12T13:40:37Z

And now? Whats the workaround for this? Facing the same issue...

tac0turtle · 2024-06-12T13:42:40Z

you would use json.unarmshal, you dont need to use cmtjson

fragwuerdig · 2024-06-12T13:49:30Z

So, ok... You are basically saying that I need to use a fixed/custom/forked version of CometBFT - because comet is using cmtjson to unmarshal the genesis file and feed it into the chain initialization...

tac0turtle · 2024-06-12T14:21:46Z

huh? what are you trying to do? none of the steps you are doing are needed.

fragwuerdig · 2024-06-13T07:12:24Z

Ok. Let me explain.

I am trying to use stock SDK 0.50.6 and CometBFT 0.38. The stock init, gentx and collect-gentxs commands will use encoding/json to marshal the genesis.json file. This means they will marshal a literal 1 as initial_height (which is an uint64 json type). CometBFT will pick up the genesis.json unmarshal it to feed it into InitChain. But it will fail to unmarshal the genesis.json, because cmtjson is expecting a string literal "1" for an uint64 data type.

So, I worked around it by using customized init, gentx and collect-gentxs commands for the chain client. I am not happy with it. But it works.

If I forgot to properly wire-up something or there is some kind of autocli or depinject way to solve this, then let me know. Happy to use stock software instead of fix-ups.

julienrbrt · 2024-06-13T08:37:32Z

Hi, as @tac0turtle said, this is an expected behavior. The SDK will always save the genesis as an app genesis.
In order to unmarshal an app genesis, use AppGenesisFromReader or AppGenesisFromFile: https://github.com/cosmos/cosmos-sdk/blob/v0.50.7/x/genutil/types/genesis.go#L91-L141. It fallback to a cometbft genesis if you are not using an app genesis yet. As the SDK handles genesis, you cannot rely on comet functions for it.
Think of the genesis as an app concern now. The SDK does the translation to cometbft when needed: e.g

cosmos-sdk/server/start.go

Lines 415 to 451 in a6844f5

    
           // getGenDocProvider returns a function which returns the genesis doc from the genesis file. 
        
           func getGenDocProvider(cfg *cmtcfg.Config) func() (node.ChecksummedGenesisDoc, error) { 
        
           	return func() (node.ChecksummedGenesisDoc, error) { 
        
           		appGenesis, err := genutiltypes.AppGenesisFromFile(cfg.GenesisFile()) 
        
           		if err != nil { 
        
           			return node.ChecksummedGenesisDoc{ 
        
           				Sha256Checksum: []byte{}, 
        
           			}, err 
        
           		} 
        
           		gen, err := appGenesis.ToGenesisDoc() 
        
           		if err != nil { 
        
           			return node.ChecksummedGenesisDoc{ 
        
           				Sha256Checksum: []byte{}, 
        
           			}, err 
        
           		} 
        
           		genbz, err := gen.AppState.MarshalJSON() 
        
           		if err != nil { 
        
           			return node.ChecksummedGenesisDoc{ 
        
           				Sha256Checksum: []byte{}, 
        
           			}, err 
        
           		} 
        
           		bz, err := json.Marshal(genbz) 
        
           		if err != nil { 
        
           			return node.ChecksummedGenesisDoc{ 
        
           				Sha256Checksum: []byte{}, 
        
           			}, err 
        
           		} 
        
           		sum := sha256.Sum256(bz) 
        
           		return node.ChecksummedGenesisDoc{ 
        
           			GenesisDoc:     gen, 
        
           			Sha256Checksum: sum[:], 
        
           		}, nil 
        
           	} 
        
           }

(see ToGenesisDoc method on AppGenesis).

As everything is abstracted, you shouldn't encounter this issue unless you are doing something wrong. Could you point us to how you are handling the genesis? init, gentx and collect-gentxs are using the app genesis functions:

cosmos-sdk/x/genutil/client/cli/gentx.go

Line 85 in c5253e8

appGenesis, err := types.AppGenesisFromFile(config.GenesisFile())

fragwuerdig · 2024-06-13T08:58:17Z

Very much appreciated. Thx.

As per issue cosmos/cosmos-sdk#20597

* fix(cmd): nibid init command * fix(scripts): nibid config for localnet * chore(mod): go mod tidy * fix(StartCmdWithOptions): set DBOpener if nil * fix(scripts): nibid config usage * fix(cmd): fix prefixes * fix(statik): fix "statik/fs: no zip data registered" * fix(genesis): decoding (ctmjson) doesnt match encoding (json) As per issue cosmos/cosmos-sdk#20597

matthiasmatt added 2 commits June 7, 2024 17:11

fix: fix marshaling for appgenesis

195fcca

chore: changelog

5371705

matthiasmatt requested a review from a team as a code owner June 7, 2024 15:54

github-actions bot added the C:x/genutil genutil module issues label Jun 7, 2024

coderabbitai bot reviewed Jun 7, 2024

View reviewed changes

tac0turtle closed this Jun 7, 2024

fragwuerdig mentioned this pull request Jun 12, 2024

[Bug]: Genesis marshmaling distinct from cometBFT #20596

Closed

1 task

SpekalsG3 added a commit to SpekalsG3/nibiru that referenced this pull request Sep 15, 2024

fix(genesis): decoding (ctmjson) doesnt match encoding (json)

c83b111

As per issue cosmos/cosmos-sdk#20597

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fix marshaling for appgenesis #20597

fix: fix marshaling for appgenesis #20597

matthiasmatt commented Jun 7, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 7, 2024 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s) (Beta)

Assessment against linked issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot Jun 7, 2024

tac0turtle commented Jun 7, 2024

fragwuerdig commented Jun 12, 2024

tac0turtle commented Jun 12, 2024

fragwuerdig commented Jun 12, 2024

tac0turtle commented Jun 12, 2024

fragwuerdig commented Jun 13, 2024

julienrbrt commented Jun 13, 2024 •

edited

Loading

fragwuerdig commented Jun 13, 2024

	* (genutil) [#20596](https://github.com/cosmos/cosmos-sdk/pull/20596) Fix marshalling service used.
	* (genutil) [#20596](https://github.com/cosmos/cosmos-sdk/pull/20596) Update marshalling in `AppGenesis` to use `cmtjson.MarshalIndent`, ensuring compatibility with CometBFT.

fix: fix marshaling for appgenesis #20597

fix: fix marshaling for appgenesis #20597

Conversation

matthiasmatt commented Jun 7, 2024 • edited by coderabbitai bot Loading

Description

Author Checklist

Reviewers Checklist

Summary by CodeRabbit

coderabbitai bot commented Jun 7, 2024 • edited Loading

Walkthrough

Changes

Sequence Diagram(s) (Beta)

Assessment against linked issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Jun 7, 2024

Choose a reason for hiding this comment

tac0turtle commented Jun 7, 2024

fragwuerdig commented Jun 12, 2024

tac0turtle commented Jun 12, 2024

fragwuerdig commented Jun 12, 2024

tac0turtle commented Jun 12, 2024

fragwuerdig commented Jun 13, 2024

julienrbrt commented Jun 13, 2024 • edited Loading

fragwuerdig commented Jun 13, 2024

matthiasmatt commented Jun 7, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 7, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

julienrbrt commented Jun 13, 2024 •

edited

Loading