Server v2 start & helpers #20288

hieuvubk · 2024-05-06T12:00:23Z

Description

Closes: #19720

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Remove CometConfig from ServerContext v2. Will get config from viper.
Make ServerContext as interface. v1 & v2 context should be used around this interface
Create config files for server v2
server & comet start in 1 cmd
Read config

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

coderabbitai · 2024-05-06T12:00:29Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

julienrbrt · 2024-05-06T13:06:36Z

Can we have a PR targeting main first with the simplification of server context?
It is easier to review and then see it used here (after merging main in server_modular)

julienrbrt · 2024-05-06T13:07:15Z

core/go.mod

@@ -4,27 +4,66 @@ go 1.21

 require (
 	cosmossdk.io/log v1.3.1
+	github.com/cometbft/cometbft v0.38.7


So we shouldn't import comet into core?

Yes, no comet, no sdk and as little as dep as possible in core.

tac0turtle · 2024-05-06T14:52:18Z

core/context/server_context.go

+type ServerContext interface {
+	GetLogger() log.Logger
+	GetViper() *viper.Viper
+	GetConfig() *cmtcfg.Config
+}
+
+func GetServerContextFromCmd(cmd *cobra.Command) ServerContext {
+	if v := cmd.Context().Value(ServerContextKey); v != nil {
+		fmt.Println("serverCtxPtr", v)
+		serverCtxPtr := v.(ServerContext)
+		return serverCtxPtr
+	}
+	return nil
+}


this is specific to server/v2 it can live there. Ideally there is no comet deep in server/v2 as well

Make sense, I will make *cmtcfg.Config as an interface

server/v2/toml.go

github-actions · 2024-05-09T09:12:18Z

@hieuvubk your pull request is missing a changelog!

julienrbrt · 2024-05-31T11:22:21Z

As think we can close this. As there is a or targeting main. And we do not put anything in the release branch anymore.

hieuvubk added 5 commits May 3, 2024 20:28

start cometserver with server

79b3ea2

server context as service

db762a8

create config file

eb20353

start server with comet server & go mod tidy

1bed5b3

lint

b8fa81e

github-actions bot added C:CLI C:x/genutil genutil module issues labels May 6, 2024

simapp go mod tidy

8a64bd6

julienrbrt reviewed May 6, 2024

View reviewed changes

kocubinski self-assigned this May 6, 2024

tac0turtle reviewed May 6, 2024

View reviewed changes

server/v2/toml.go Outdated Show resolved Hide resolved

hieuvubk mentioned this pull request May 7, 2024

Remove CometBFT Config from ServerContext #20311

Closed

12 tasks

hieuvubk added 2 commits May 9, 2024 15:04

fix gentxs

03aef7a

test scripts

245c73f

github-actions bot added the Type: Build label May 9, 2024

hieuvubk added 2 commits May 9, 2024 15:22

unused

b661120

fix

4f393b0

hieuvubk marked this pull request as ready for review May 9, 2024 09:12

hieuvubk requested a review from a team as a code owner May 9, 2024 09:12

hieuvubk added 4 commits May 10, 2024 18:20

clean core/context

f8a7bca

helper

8af67ed

simplier server v2

0fe9762

genutil using client helper

64a6ec6

tac0turtle mentioned this pull request May 17, 2024

refactor(core,server): make commands not rely on server context #20422

Merged

12 tasks

should start

3cf2124

julienrbrt closed this Jun 5, 2024

julienrbrt deleted the hieu/start_v2 branch June 5, 2024 07:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Server v2 start & helpers #20288

Server v2 start & helpers #20288

hieuvubk commented May 6, 2024

coderabbitai bot commented May 6, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

julienrbrt commented May 6, 2024

julienrbrt May 6, 2024

hieuvubk May 6, 2024

julienrbrt May 6, 2024

tac0turtle May 6, 2024

hieuvubk May 6, 2024

github-actions bot commented May 9, 2024

julienrbrt commented May 31, 2024

Server v2 start & helpers #20288

Server v2 start & helpers #20288

Conversation

hieuvubk commented May 6, 2024

Description

Author Checklist

Reviewers Checklist

coderabbitai bot commented May 6, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

julienrbrt commented May 6, 2024

julienrbrt May 6, 2024

Choose a reason for hiding this comment

hieuvubk May 6, 2024

Choose a reason for hiding this comment

julienrbrt May 6, 2024

Choose a reason for hiding this comment

tac0turtle May 6, 2024

Choose a reason for hiding this comment

hieuvubk May 6, 2024

Choose a reason for hiding this comment

github-actions bot commented May 9, 2024

julienrbrt commented May 31, 2024

coderabbitai bot commented May 6, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)