fix(x/tx): don't shadow Amino marshalling error messages

[Pitasi]

Description

A minor thing but it took me a while to figure out where the problem was when marshalling a message of mine.

The error (trimmed for readability) was:

cannot marshal response pagination:{total:1} [...]: unexpected end of JSON input

While digging in the code I found that the real Amino error was not being considered, and buf.Bytes() was being tried to use anyway, but only when indenting the response.

In fact, after trying the same query from CLI with --no-indent, I got the real error:

cannot marshal response pagination:{total:1} [...]: field identifier within a oneof must have the amino.oneof_type_name option set

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling in transactions to ensure clearer error messages are displayed, enhancing user experience during transaction processing.

[coderabbitai]

Walkthrough

Walkthrough

The recent update focuses on enhancing error handling and interoperability in the system. A significant bug fix was made to ensure that errors related to Amino marshalling are properly reported, preventing their shadowing. Additionally, the system has transitioned to a hybrid resolver approach, moving away from relying solely on the protov2 registry. This change aims to improve the system's flexibility and efficiency in processing transactions.

Changes

File(s)	Change Summary
x/tx/CHANGELOG.md	Bug fix for Amino marshalling error message shadowing and adoption of a hybrid resolver.
x/tx/signing/aminojson/.../json_marshal.go	Updated error handling in Marshal method to handle indentation errors and improve error response.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Status

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between edd1c71 and bff9d2c.

Files selected for processing (2)

• x/tx/CHANGELOG.md (1 hunks)
• x/tx/signing/aminojson/json_marshal.go (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• x/tx/signing/aminojson/json_marshal.go

Additional Context Used

Path-based Instructions (1)

x/tx/CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

Additional comments not posted (1)

x/tx/CHANGELOG.md (1)

44-44: Ensure the description under "Bug Fixes" clearly explains the impact of the fix.

While the entry for PR #19955 under "Bug Fixes" is concise, consider expanding it to briefly describe how the fix improves error message clarity during Amino marshalling. This will provide better context for readers.