Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/**)!: genesis return errors #19740
refactor(x/**)!: genesis return errors #19740
Changes from 7 commits
0e3db68
7519ce8
aba3118
ebc26d7
bf63bac
2720016
bcf4a04
0ec116b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed, we can just return as it was
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is needed , because staking module need.
cosmos-sdk/x/staking/keeper/genesis.go
Line 227 in cdc3291
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your snippet does the same thing as previously but is just more verbose, this is why it can be reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
o, i see, i will do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry is clear and adheres to the changelog standards. However, consider revising the verb form for better grammatical agreement in the summary of other entries.
For example, in the entry for
[#19637]
, the phrase "doesn't take a message router anymore" could be improved for clarity.Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry is clear and adheres to the changelog standards. However, consider revising the verb form for better grammatical agreement in the summary of other entries.
For example, in the entry for
[#18636]
, the phrase "methods now returns an error" could be improved for grammatical accuracy.Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entry for PR #19740 could be enhanced for clarity. Consider specifying the modules affected by the changes to
InitGenesis
andExportGenesis
to provide more context to the reader.Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry is clear and adheres to the changelog standards. However, consider revising the verb form for better grammatical agreement in the summary of other entries.
For example, in the entry for
[#19101]
, the phrase "Add message based params configuration" could be improved for clarity.Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry is clear and adheres to the changelog standards. However, consider revising the verb form for better grammatical agreement in the summary of other entries.
For example, in the entry for
[#19638]
, the phrase "so nobaseapp.MessageRouter
is required isNewKeeper
anymore" could be improved for clarity and grammatical accuracy.Committable suggestion