Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add v0.47.10 and v0.50.5 changelogs #19717

Merged
merged 5 commits into from
Mar 12, 2024
Merged

chore: add v0.47.10 and v0.50.5 changelogs #19717

merged 5 commits into from
Mar 12, 2024

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Mar 11, 2024

Description

Add v0.47.10 and v0.50.5 changelogs to main.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features
    • Added an option to disable the block gas meter during transaction execution in BaseApp.
  • Improvements
    • Introduced CLI consistency improvements.
    • Allowed empty public keys in GetSignBytesAdapter.
  • Bug Fixes
    • Fixed bugs related to proposal tally fetching, staking genesis export, custom signers injection, and delegator slashing bypass.
    • Resolved an issue in baseapp.ValidateVoteExtensions helper.

Copy link
Contributor

coderabbitai bot commented Mar 11, 2024

Walkthrough

Walkthrough

Version v0.50.5 brings a new option to BaseApp that allows disabling the block gas meter during transaction execution. It also includes enhancements for CLI consistency and now supports empty public keys in GetSignBytesAdapter. Additionally, this version addresses various bugs related to proposal tally fetching, staking genesis export, custom signers injection, delegator slashing bypass, and a bug in baseapp.ValidateVoteExtensions helper.

Changes

Files Change Summary
BaseApp Added option to disable the block gas meter during transaction execution.
Various CLI files Introduced improvements for CLI consistency.
GetSignBytesAdapter Allowed empty public keys.
Multiple files related to proposals, staking, custom signers, and slashing Fixed bugs in proposal tally fetching, staking genesis export, custom signers injection, delegator slashing bypass, and in baseapp.ValidateVoteExtensions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@julienrbrt julienrbrt marked this pull request as ready for review March 12, 2024 12:56
@julienrbrt julienrbrt requested a review from a team as a code owner March 12, 2024 12:56
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yml

Commits Files that changed from the base of the PR and between d961aef and acc4071.
Files selected for processing (1)
  • CHANGELOG.md (2 hunks)
Additional comments: 2
CHANGELOG.md (2)
  • 163-181: The changelog for version v0.50.5 is well-documented, providing a clear overview of the features, improvements, and bug fixes introduced in this version. Each entry is correctly linked to its corresponding GitHub pull request, which is good for traceability. However, it's important to ensure that the descriptions are accurate and that they reflect the changes made in the linked pull requests. Additionally, for the security advisories (lines 179 and 180), it's crucial to verify that the provided links are correct and lead to the detailed advisory pages. This helps in maintaining the integrity and reliability of the changelog.
  • 599-605: The changelog entries for version v0.47.10 accurately document the bug fixes introduced in this version. The inclusion of a security advisory link (line 603) is particularly important for transparency and user awareness. It's essential to ensure that the advisory link is correct and accessible. The entry on line 604 regarding the db_backend type fix provides sufficient detail and is linked to the relevant pull request, which aids in understanding the context of the change. Overall, the changelog for this version is clear and informative.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yml

Commits Files that changed from the base of the PR and between acc4071 and 5ac0536.
Files selected for processing (1)
  • CHANGELOG.md (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.md

@tac0turtle tac0turtle added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit a569ba6 Mar 12, 2024
56 of 57 checks passed
@tac0turtle tac0turtle deleted the julien/changelogs branch March 12, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants