Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(baseapp): add option to disable block gas meter #19626
feat(baseapp): add option to disable block gas meter #19626
Changes from 1 commit
4bcd297
a033aeb
6f3226f
3f57035
8166036
e3ddbc1
2305a8a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of the
disableBlockGasMeter
field to theBaseApp
struct introduces the capability to disable the block gas meter. This change is crucial for supporting parallel transaction execution without the complications of block gas metering. However, it's important to ensure that this feature is well-documented, especially the safety aspects mentioned in the comment. The comment mentions that it's safe if validators validate the total gas wanted in the proposal, which implies a reliance on external validation mechanisms. This should be clearly documented in the official documentation to avoid misuse of the feature.Consider enhancing the documentation around this feature, both in code comments and the official Cosmos SDK documentation, to clearly explain its usage, the conditions under which it is safe to disable the block gas meter, and the responsibilities of validators in this context.