-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updates to abci documentation #19309
Conversation
Co-Authored-By: Adi Seredinschi <[email protected]>
WalkthroughThe updates focus on refining the documentation and functionality of the ABCI (Application Blockchain Interface), enhancing clarity and precision across several aspects. Changes include clearer language in the introduction, a functional tweak in proposal preparation, detailed explanation on proposal processing, and a semantic update in vote extensions. These modifications aim to improve the understanding and implementation of ABCI without altering its core logic. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: .coderabbit.yml
Files selected for processing (4)
- docs/build/abci/00-introduction.md (3 hunks)
- docs/build/abci/01-prepare-proposal.md (1 hunks)
- docs/build/abci/02-process-proposal.md (2 hunks)
- docs/build/abci/03-vote-extensions.md (1 hunks)
Files skipped from review due to trivial changes (3)
- docs/build/abci/00-introduction.md
- docs/build/abci/02-process-proposal.md
- docs/build/abci/03-vote-extensions.md
Additional comments: 1
docs/build/abci/01-prepare-proposal.md (1)
- 37-44: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-41]
The documentation provides a clear explanation of the
PrepareProposal
phase within the Cosmos SDK's ABCI documentation. However, ensure that all technical terms and code references are accurate and up-to-date with the latest Cosmos SDK versions to maintain the documentation's reliability and usefulness for developers.
Description
It was requested to make these small changes for the ABCI docs, the conversation can be seen here
@adizere
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
PrepareProposal
process and its importance.ProcessProposal
module, including validator actions and failure scenarios.