-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(x/staking): Refactor GetLastValidators (backport #19226) #19230
Conversation
(cherry picked from commit a69836b) # Conflicts: # CHANGELOG.md # x/staking/keeper/validator.go
this is state breaking, we would need to revert other versions. I dont think we can backport this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking merge to double check assumptions
So the reason I feel safe backporting this is because prior it would error and thus halt a chain. Now, the chain would not halt with such a change. After our call today, we still need to understand if this truly fixes it. If any missing pieces are discovered, I'll address them in a followup PR to |
This PR is actually pointless.
|
This is an automatic backport of pull request #19226 done by Mergify.
Cherry-pick of a69836b has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com