-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add consensus pubkey docs #19081
Conversation
WalkthroughThe changes introduce a new feature for rotating a validator's consensus public key within the staking module of a blockchain system. This feature allows for instant rotation with constraints on frequency and associated fees. It includes data structures for tracking, querying, and handling rotations, and updates the relevant documentation and client commands. The modifications are part of a larger effort to break down a complex pull request into smaller, more manageable pieces for review. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
* parameters can be decided by governance and stored in genesis file. | ||
* key rotation fee | ||
* a validator should pay `KeyRotationFee` to rotate the consensus key which is calculated as below | ||
* `KeyRotationFee` = (max(`VotingPowerPercentage` *100, 1)* `InitialKeyRotationFee`) * 2^(number of rotations in `ConsPubKeyRotationHistory` in recent unbonding period) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: what "in recen unbonding period" means? In the above paragraph it says that only 1 rotation is allow per unbonding window.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the above paragraph it says that only 1 rotation is allow per unbonding window.
Yeah, currently the rotations are allowed once in unbonding period, but this formula applies when we allow more than one rotation in unbonding period of time.
Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: samricotta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to Sam's comments, let's fix those and merge
Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: samricotta <[email protected]>
Description
ref: #18141
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...