feat(x/bank): adding DenomOwnersByQuery for denom owners for token #18956
Conversation
WalkthroughThe Cosmos SDK repository has undergone changes to address issues with querying denoms (token denominations) that contain slashes. The Changes
Assessment against linked issues
The code changes appear to address the primary objectives of the linked issue, enhancing the Cosmos SDK's ability to handle denom queries, especially for those containing problematic characters like slashes. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
I don't want to break current |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
julienrbrt
changed the title
There was a problem hiding this comment.
The new query should be added here as well:
Line 737 in b16aa35
| // denomination. | ||
| // | ||
| // Since: cosmos-sdk 0.50.3 | ||
| message QueryDenomOwnersByQueryRequest { |
There was a problem hiding this comment.
Regarding the discussion about the since comment, it seems there is a consensus that it should be included and specify the version 0.50.3 or 0.50.4 depending on when the PR is merged. This should be finalized before merging.
|
@Mergifyio backport release/v0.50.x |
✅ Backports have been created
|
…18956) Co-authored-by: Sai Kumar <[email protected]> (cherry picked from commit dee9eda) # Conflicts: # CHANGELOG.md # client/docs/swagger-ui/swagger.yaml # proto/cosmos/protocolpool/v1/tx.proto # x/bank/CHANGELOG.md # x/bank/keeper/grpc_query.go # x/bank/types/query.pb.go
…ackport #18956) (#19007) Co-authored-by: gsai967 <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…osmos#18956) Co-authored-by: Sai Kumar <[email protected]>
Description
Closes: #18917
The current
DenomOwnersquery does not works with token denom values which have "/" in them , we have to passdenomvalue as query string toDenomOwners.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...