fix(abci): add ExecModeVerifyVoteExtension

[alexanderbez]

Description

Closes: #18914

Add a new exec mode for the VerifyVoteExtension ABCI method. In addition, update the ctx when calling the app's handler with relevant fields.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

[coderabbitai]

Walkthrough

The changes in the cosmos/cosmos-sdk repository involve the addition of a new execution mode for verifying vote extensions in the ABCI 2.0 API. This update aims to maintain consistency across execution modes for different ABCI methods. The changes are implemented across several files, primarily within the baseapp and types modules, ensuring that the new execution mode is integrated and the context is updated to support the verification process.

Changes

Files	Change Summary
baseapp/baseapp.go, types/context.go	Introduced a new execution mode for verifying vote extensions.
baseapp/abci.go	Updated context to include new attributes for vote extension verification.

Assessment against linked issues

Objective	Addressed	Explanation
Add an execution mode for VerifyVoteExtensions for consistency (#18914)	✅	The addition of execModeVerifyVoteExtension aligns with the proposed solution to maintain consistency.
Ensure every ABCI 2.0 API has an execution mode	✅	The new execution mode for VerifyVoteExtensions ensures that all ABCI 2.0 APIs now have corresponding execution modes.
Remove execution mode from ExtendVote if deemed unnecessary (#18914)	❓	The summary provided does not indicate whether the execution mode for ExtendVote was removed or retained, thus it's unclear if this part of the proposal was considered.

The changes appear to address the main objective of issue #18914, which is to introduce an execution mode for VerifyVoteExtensions, thereby ensuring consistency across all ABCI 2.0 APIs. The decision regarding the ExtendVote execution mode is not clear from the summary provided.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

• You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
  • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.