Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/gov): add max cancel voting period param #18856
feat(x/gov): add max cancel voting period param #18856
Changes from 1 commit
72e8739
16604d0
bd57ad8
53671ae
c64fcd9
b98d59b
2c29080
18fc56e
0ae7151
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Check failure on line 317 in proto/cosmos/gov/v1/gov.proto
GitHub Actions / break-check
Check failure on line 317 in proto/cosmos/gov/v1/gov.proto
GitHub Actions / break-check
Check failure on line 317 in proto/cosmos/gov/v1/gov.proto
GitHub Actions / break-check
Check failure on line 323 in proto/cosmos/gov/v1/gov.proto
GitHub Actions / break-check
Check failure on line 323 in proto/cosmos/gov/v1/gov.proto
GitHub Actions / break-check
Check failure on line 323 in proto/cosmos/gov/v1/gov.proto
GitHub Actions / break-check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: what does rate mean in
maxCancelPeriodRate
? MaybemaxCancelPeriod
ormaxCancelPeriodDuration
and renamemaxCancelPeriod
tomaxCancelTime
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, it's not a duration, my bad