-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add ante precision #18709
docs: add ante precision #18709
Conversation
WalkthroughThe recent updates involve clarifications on how transaction handlers process nested messages within a blockchain framework. Specifically, the documentation now explains that ante handlers only execute on the outermost message of a transaction, while inner messages bypass this step and go directly to the message router. Additionally, the behavior of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
@@ -112,6 +112,10 @@ A copy of the cached context is provided to the `AnteHandler`, which performs li | |||
|
|||
For example, the [`auth`](https://github.com/cosmos/cosmos-sdk/tree/main/x/auth) module `AnteHandler` checks and increments sequence numbers, checks signatures and account numbers, and deducts fees from the first signer of the transaction - all state changes are made using the `checkState`. | |||
|
|||
:::warning | |||
Note that ante handlers only run on a transaction. If a transaction embed multiple messages (like some x/authz, x/gov txs for instance), the ante handlers will run on the outer message. Inner messages are mostly directly routed to the [message router](https://docs.cosmos.network/main/learn/advanced/baseapp#msg-service-router) and skip the ante handler. This is something to keep in mind when designing your own ante handler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... the ante handlers will run on the outer message.
I would perhaps consider rephrasing this. I think what you mean to say is that the AnteHandler chain has context or awareness of only the outer messages, not that it runs or processes them. I just want to avoid ambiguity or confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
(cherry picked from commit 49825ea) # Conflicts: # x/circuit/README.md
(cherry picked from commit 49825ea) # Conflicts: # x/circuit/README.md
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Description
related #18637
A-26
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...