refactor(types)!: removed txEncoder from global config

[bizk]

Description

Closes: #18696

ref #7448

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

[coderabbitai]

Walkthrough

The cosmos-sdk repository has undergone a significant update, removing the global configuration for txEncoder. This change affects the types module, eliminating the txEncoder field from the Config struct, along with associated methods for setting and getting the txEncoder. Additionally, purpose and coinType fields have also been removed. The test suite has been updated accordingly, with tests for txEncoder removed and other test logic updated.

Changes

File Path	Change Summary
CHANGELOG.md	Removed global txEncoder configuration in pull request #18695.
types/config.go	Removed txEncoder, purpose, and coinType fields and associated methods from Config struct.
types/.../config_test.go	Removed errors package import, deleted TestConfig_SetTxEncoder function, and updated test logic in TestConfig_SetFullFundraiserPath.

Assessment against linked issues

Objective	Addressed	Explanation
Remove global TxEncoder	✅	The global txEncoder has been successfully removed, aligning with the objective outlined in issue #18696.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can reply to a review comment made by CodeRabbit.
• You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
• You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [15-15]

The changelog mentions a security vulnerability identified in the x/bank module in the v0.41.x series, which is critical and should be highlighted for users running non-Cosmos Hub chains.

[julienrbrt]

Can we always precise the alternative when we remove something from the config?

Maybe it would be nice to add an UPGRADING.md section on the global config removals, so there will be one place to look at it.

[bizk]

This one has not been used anywhere, I think it is deprecated, thats why I didn't add an alternative, TxEncoder is used on other parts but not the one dfined as a global config. I dont see any use cases where someone would want some sort of global txEncoder

[julienrbrt]

A quick search here: https://sourcegraph.com/search?q=context%3Aglobal+.GetTxEncoder%28%29&patternType=standard&sm=1&groupBy=repo shows indeed that it is only used in v0.45 chains / fork. Then I guess it is fine indeed.

[tac0turtle]

thank you!! looks good other than the comment from julian

[julienrbrt]

ACK. However, we need the changelog to be under API breaking instead of improvements. Same for the line just above about #18372 btw.

[julienrbrt]

I still have the same comment about the changelog.