feat(store/v2): add SetInitialVersion in SC

[cool-develope]

Description

Closes: #18597

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features

  • Introduced the ability to set the initial version for various data structures, enhancing control over versioning.

• Enhancements

  • Updated methods to handle the setting of initial versions, ensuring consistency across the application.

• Refactor

  • Modified existing logic to integrate the new initial version setting functionality.

[coderabbitai]

Walkthrough

Walkthrough

The codebase has been updated to include a new feature that allows setting an initial version for various tree and store structures. This feature has been implemented across multiple files, with the addition of a SetInitialVersion method to interfaces and structs that manage versioning. The changes ensure that any type implementing these interfaces or using these structs can now specify an initial version, which could be important for state management and data migration scenarios.

Changes

File(s)	Change Summary
.../iavl/tree.go	Added SetInitialVersion method to IavlTree struct.
.../commitment/store.go	Introduced SetInitialVersion method to CommitStore type.
.../commitment/tree.go	Added SetInitialVersion method to Tree interface.
.../database.go	Included SetInitialVersion method in Committer interface.
.../root/store.go	Modified SetInitialVersion method logic within Store type.

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[github-actions]

@cool-develope your pull request is missing a changelog!

[coderabbitai]

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 8fb6205 and 8481c2d.

Files selected for processing (5)

• store/commitment/iavl/tree.go (1 hunks)
• store/commitment/store.go (1 hunks)
• store/commitment/tree.go (1 hunks)
• store/database.go (1 hunks)
• store/root/store.go (1 hunks)

Additional comments: 5

store/commitment/store.go (2)

• 119-126: The implementation of SetInitialVersion correctly iterates through each tree in multiTrees and sets the initial version. This aligns with the PR objectives and the summary provided.

• 119-126: Verify that all concrete implementations of the Tree interface have been updated to include the new SetInitialVersion method as per the interface contract changes.

---

The attempt to verify the implementation of the SetInitialVersion method in concrete implementations of the Tree interface did not yield results due to a syntax error in the command. However, the absence of output does not necessarily indicate that the method is unimplemented in the relevant types. Given the error in the command execution, we cannot conclusively determine whether the codebase is consistent with the changes described in the PR summary.

Final review comment:

Verify that all concrete implementations of the Tree interface have been updated to include the new SetInitialVersion method as per the interface contract changes. The initial verification command did not yield results due to a syntax error, so further verification is needed to ensure consistency across the codebase.

store/commitment/tree.go (1)

• 20-26: The addition of the SetInitialVersion method to the Tree interface is correctly implemented and aligns with the PR objectives and summaries.

store/database.go (2)

• 72-76: The addition of SetInitialVersion to the Committer interface is consistent with the PR objectives and the AI-generated summaries. This change will require all concrete implementations of the Committer interface to implement this new method.

• 72-76: Please ensure that all concrete types implementing the Committer interface are updated to include the new SetInitialVersion method to maintain compatibility.

[coderabbitai]

The SetInitialVersion method should not directly set the initialVersion field according to the PR objectives and the summary. The direct assignment should be removed to align with the intended changes.

func (s *Store) SetInitialVersion(v uint64) error {
-   s.initialVersion = v
    return s.stateCommitment.SetInitialVersion(v)
}

---

Committable suggestion

❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	func (s *Store) SetInitialVersion(v uint64) error {
	s.initialVersion = v
	// TODO(bez): Call SetInitialVersion on s.stateCommitment.
	//
	// Ref: https://github.com/cosmos/cosmos-sdk/issues/18597
	return nil
	return s.stateCommitment.SetInitialVersion(v)
	func (s *Store) SetInitialVersion(v uint64) error {
	return s.stateCommitment.SetInitialVersion(v)
	}

[coderabbitai]

The SetInitialVersion method does not handle the error that might be returned by t.tree.SetInitialVersion(version). It is important to handle this error to ensure that any issues with setting the initial version are properly reported and can be acted upon.

func (t *IavlTree) SetInitialVersion(version uint64) error {
-   t.tree.SetInitialVersion(version)
-   return nil
+   return t.tree.SetInitialVersion(int64(version))
}

---

Committable suggestion

❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	func (t *IavlTree) SetInitialVersion(version uint64) error {
	t.tree.SetInitialVersion(version)
	return nil
	func (t *IavlTree) SetInitialVersion(version uint64) error {
	return t.tree.SetInitialVersion(int64(version))
	}

[alexanderbez]

ez pz, thanks @cool-develope!