fix(baseapp)!: postHandler should run regardless of result (backport #18627) #18638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit b2084dc) # Conflicts: # CHANGELOG.md
|
Important Auto Review SkippedBot user detected. To trigger a single review, invoke the TipsChat with CodeRabbit Bot (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
925
to
949
| if err == nil { | ||
| result, err = app.runMsgs(runMsgCtx, msgs, msgsV2, mode) | ||
| } | ||
| if err == nil { | ||
| // Run optional postHandlers. | ||
| // | ||
| // Note: If the postHandler fails, we also revert the runMsgs state. | ||
| if app.postHandler != nil { | ||
| // The runMsgCtx context currently contains events emitted by the ante handler. | ||
| // We clear this to correctly order events without duplicates. | ||
| // Note that the state is still preserved. | ||
| postCtx := runMsgCtx.WithEventManager(sdk.NewEventManager()) | ||
|
|
||
| newCtx, err := app.postHandler(postCtx, tx, mode == execModeSimulate, err == nil) | ||
| if err != nil { | ||
| return gInfo, nil, anteEvents, err | ||
| } | ||
|
|
||
| result.Events = append(result.Events, newCtx.EventManager().ABCIEvents()...) | ||
| // Run optional postHandlers (should run regardless of the execution result). | ||
| // | ||
| // Note: If the postHandler fails, we also revert the runMsgs state. | ||
| if app.postHandler != nil { | ||
| // The runMsgCtx context currently contains events emitted by the ante handler. | ||
| // We clear this to correctly order events without duplicates. | ||
| // Note that the state is still preserved. | ||
| postCtx := runMsgCtx.WithEventManager(sdk.NewEventManager()) | ||
|
|
||
| newCtx, err := app.postHandler(postCtx, tx, mode == execModeSimulate, err == nil) | ||
| if err != nil { | ||
| return gInfo, nil, anteEvents, err | ||
| } | ||
|
|
||
| result.Events = append(result.Events, newCtx.EventManager().ABCIEvents()...) | ||
| } | ||
|
|
||
| if err == nil { | ||
| if mode == execModeFinalize { | ||
| // When block gas exceeds, it'll panic and won't commit the cached store. | ||
| consumeBlockGas() |
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).runTx (baseapp/baseapp.go:798)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).deliverTx (baseapp/baseapp.go:728)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).internalFinalizeBlock (baseapp/baseapp.go:680)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/baseapp.go:837)
julienrbrt
reviewed
Dec 6, 2023
| @@ -58,6 +58,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| * [#18531](https://github.com/cosmos/cosmos-sdk/pull/18531) Baseapp's `GetConsensusParams` returns an empty struct instead of panicking if no params are found. | |||
| * (client/tx) [#18472](https://github.com/cosmos/cosmos-sdk/pull/18472) Utilizes the correct Pubkey when simulating a transaction. | |||
| * (baseapp) [#18486](https://github.com/cosmos/cosmos-sdk/pull/18486) Fixed FinalizeBlock calls not being passed to ABCIListeners. | |||
| * (baseapp) [#18627](https://github.com/cosmos/cosmos-sdk/pull/18627) Post handlers are run on non successful transaction executions too. | |||
There was a problem hiding this comment.
I am for merging this into v0.50.2 with the assumption that there are no user of v0.50.1 on prod yet.
With the amount of bug fixes we will add to v0.50.2, I think no one with launch on prod with v0.50.1.
I have checked sourcegraph and github which seems to confirm that. Maybe only berachain (so cc-ing @itsdevbear)?
There was a problem hiding this comment.
Seems reasonable to me. ACK
There was a problem hiding this comment.
We have a testnet on v0.50.1 yuh.
There was a problem hiding this comment.
We don't use post handler so this is non consensus breaking for us. All good
julienrbrt
approved these changes
Dec 6, 2023
alexanderbez
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #18627 done by Mergify.
Cherry-pick of b2084dc has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com