Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client/v2/offchain): sign and verify file #18626

Merged
merged 36 commits into from
Jan 24, 2024
Merged

feat(client/v2/offchain): sign and verify file #18626

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
b024711
add: off-chain sign and verify file
JulianToledano Dec 4, 2023
bec788d
Merge branch 'main' into julian/off-chain-poc
JulianToledano Dec 11, 2023
bfa6ec4
fix: package name
JulianToledano Dec 11, 2023
b3743b8
update: remove some dependencies
JulianToledano Dec 12, 2023
55c5a98
Update client/v2/internal/offchain/msgSignArbitraryData.proto
JulianToledano Dec 12, 2023
c640e72
fix: use autocli keyring
JulianToledano Dec 13, 2023
4742f2a
offchain sig
JulianToledano Dec 13, 2023
73becd5
update: encoding, flags
JulianToledano Dec 13, 2023
08f459a
add: tests
JulianToledano Dec 14, 2023
22866b6
update: docs
JulianToledano Dec 14, 2023
029bcc2
add: output format
JulianToledano Dec 15, 2023
d69a083
fix: lint
JulianToledano Dec 15, 2023
f0289a5
fix
JulianToledano Dec 15, 2023
da2ef9e
Merge branch 'main' into julian/off-chain-poc
JulianToledano Dec 15, 2023
8af522f
add: changelog
JulianToledano Dec 15, 2023
edeb06b
add: rabbit suggestions
JulianToledano Dec 15, 2023
3d06698
fix: panic
JulianToledano Dec 15, 2023
fa7fe5b
fix: panic
JulianToledano Dec 15, 2023
61db866
fix: empty error
JulianToledano Dec 15, 2023
ea790a7
fix: t.Helper()
JulianToledano Dec 19, 2023
9f33e10
Update client/v2/offchain/builder.go
JulianToledano Jan 8, 2024
5654037
godoc
JulianToledano Jan 8, 2024
2581564
fix: snake case in proto
JulianToledano Jan 8, 2024
4010f9f
don't use x/auth
JulianToledano Jan 8, 2024
7d0db42
add: test
JulianToledano Jan 8, 2024
ef60b05
del: x/auth
JulianToledano Jan 8, 2024
520f720
del: x/auth from tests
JulianToledano Jan 9, 2024
92cf87b
Merge branch 'main' into julian/off-chain-poc
JulianToledano Jan 10, 2024
19ba61f
update: use only textual
JulianToledano Jan 22, 2024
3e1daa3
update: remove signmodes
JulianToledano Jan 22, 2024
c92ebc5
add: output document flag
JulianToledano Jan 23, 2024
3c8c664
add: hex encoding
JulianToledano Jan 23, 2024
35c2a30
add: Readme
JulianToledano Jan 23, 2024
e7a8fa8
gosec
JulianToledano Jan 23, 2024
6e78084
fix
JulianToledano Jan 23, 2024
5494a37
fix: readme
JulianToledano Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/v2/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Features

* [#18626](https://github.com/cosmos/cosmos-sdk/pull/18626) Support for off-chain signing and verification of a file.
* [#18461](https://github.com/cosmos/cosmos-sdk/pull/18461) Support governance proposals.

### API Breaking Changes
Expand Down
20 changes: 20 additions & 0 deletions client/v2/internal/offchain/msgSignArbitraryData.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
syntax = "proto3";

package offchain;

import "cosmos_proto/cosmos.proto";
import "cosmos/msg/v1/msg.proto";
import "amino/amino.proto";

// MsgSignArbitraryData defines an arbitrary, general-purpose, off-chain message
message MsgSignArbitraryData {
option (amino.name) = "offchain/MsgSignArbitraryData";
option (cosmos.msg.v1.signer) = "signer";
// AppDomain is the application requesting off-chain message signing
string appDomain = 1;
JulianToledano marked this conversation as resolved.
Show resolved Hide resolved
// Signer is the sdk.AccAddress of the message signer
string signer = 2 [(cosmos_proto.scalar) = "cosmos.AddressString"];
// Data represents the raw bytes of the content that is signed (text, json, etc)
string data = 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data field is still a string. If binary data support is required, consider changing this field to bytes to handle binary data more effectively.

- string data = 3;
+ bytes data = 3;
Committable suggestion

❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
string data = 3;
bytes data = 3;

}

Loading
Loading