-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client/v2/offchain): sign and verify file #18626
Merged
Merged
Changes from 29 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
b024711
add: off-chain sign and verify file
JulianToledano bec788d
Merge branch 'main' into julian/off-chain-poc
JulianToledano bfa6ec4
fix: package name
JulianToledano b3743b8
update: remove some dependencies
JulianToledano 55c5a98
Update client/v2/internal/offchain/msgSignArbitraryData.proto
JulianToledano c640e72
fix: use autocli keyring
JulianToledano 4742f2a
offchain sig
JulianToledano 73becd5
update: encoding, flags
JulianToledano 08f459a
add: tests
JulianToledano 22866b6
update: docs
JulianToledano 029bcc2
add: output format
JulianToledano d69a083
fix: lint
JulianToledano f0289a5
fix
JulianToledano da2ef9e
Merge branch 'main' into julian/off-chain-poc
JulianToledano 8af522f
add: changelog
JulianToledano edeb06b
add: rabbit suggestions
JulianToledano 3d06698
fix: panic
JulianToledano fa7fe5b
fix: panic
JulianToledano 61db866
fix: empty error
JulianToledano ea790a7
fix: t.Helper()
JulianToledano 9f33e10
Update client/v2/offchain/builder.go
JulianToledano 5654037
godoc
JulianToledano 2581564
fix: snake case in proto
JulianToledano 4010f9f
don't use x/auth
JulianToledano 7d0db42
add: test
JulianToledano ef60b05
del: x/auth
JulianToledano 520f720
del: x/auth from tests
JulianToledano 92cf87b
Merge branch 'main' into julian/off-chain-poc
JulianToledano 19ba61f
update: use only textual
JulianToledano 3e1daa3
update: remove signmodes
JulianToledano c92ebc5
add: output document flag
JulianToledano 3c8c664
add: hex encoding
JulianToledano 35c2a30
add: Readme
JulianToledano e7a8fa8
gosec
JulianToledano 6e78084
fix
JulianToledano 5494a37
fix: readme
JulianToledano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package offchain; | ||
|
|
||
| import "cosmos_proto/cosmos.proto"; | ||
| import "cosmos/msg/v1/msg.proto"; | ||
| import "amino/amino.proto"; | ||
|
|
||
| // MsgSignArbitraryData defines an arbitrary, general-purpose, off-chain message | ||
| message MsgSignArbitraryData { | ||
| option (amino.name) = "offchain/MsgSignArbitraryData"; | ||
| option (cosmos.msg.v1.signer) = "signer"; | ||
| // AppDomain is the application requesting off-chain message signing | ||
| string app_domain = 1; | ||
| // Signer is the sdk.AccAddress of the message signer | ||
| string signer = 2 [(cosmos_proto.scalar) = "cosmos.AddressString"]; | ||
| // Data represents the raw bytes of the content that is signed (text, json, etc) | ||
| string data = 3; | ||
| } | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
datafield is still astring. If binary data support is required, consider changing this field tobytesto handle binary data more effectively.Committable suggestion