-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(codec/unknownproto): use official descriptorpb types, do not rely on gogo code gen types. #18541
Merged
+113
−46
Merged
refactor(codec/unknownproto): use official descriptorpb types, do not rely on gogo code gen types. #18541
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8ada39e
make unknown proto not use gogo code gen types, it now uses descripto…
bf53128
chore: CHANGELOG.md
1dfa602
lint
67b3b8a
Merge branch 'main' into tip/baseapp/use_x_tx
testinginprod e4f6e44
address PR reviews
b663898
nicer panic debugging
a0e9770
more descriptive CHANGELOG.md
80211c4
address PR reviews 2
bd6d723
add spacing in default case
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error struct
errMismatchedWireType
should include the expected and actual wire types usingdescriptorpb.FieldDescriptorProto_Type
instead ofprotowire.Type
to align with the refactor.