Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fix gen-tx #1824

Merged
merged 3 commits into from
Jul 26, 2018
Merged

WIP fix gen-tx #1824

merged 3 commits into from
Jul 26, 2018

Conversation

rigelrozanski
Copy link
Contributor

This PR should close #1804

breaking changes were made in #1373 which broke the gen-tx mechanism in init.

Example commands which demonstrate the break:

gaiad init gen-tx --name=foo --home=$HOME/foobar                                           
 .............. > respond with some JSON indicating success 
gaiad init --gen-txs -o --home=$HOME/foobar
ERROR: Error{The genesis file must have at least one validator}

That final error should not be occurring. (basically non of the validators from any gen-tx are being processed and added to the genesis.json)

The current roll-back (aka my first commit here) has the Tendermint validators in the genesis file, which I think we've already removed? Not totally sure, I'm assuming that still needs to be updated in this PR @mossid

  • Linked to github-issue with discussion and accepted design
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 25, 2018

Codecov Report

Merging #1824 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #1824      +/-   ##
===========================================
- Coverage    63.44%   63.42%   -0.02%     
===========================================
  Files          117      117              
  Lines         6938     6940       +2     
===========================================
  Hits          4402     4402              
- Misses        2281     2283       +2     
  Partials       255      255

@alexanderbez
Copy link
Contributor

alexanderbez commented Jul 26, 2018

This also breaks the make localnet-stop/start I believe.

@cwgoes does this relate to what I brought up earlier? Something along the lines of ResponseInitChain was brought up?

@cwgoes
Copy link
Contributor

cwgoes commented Jul 26, 2018

Huh I don't think we ought to need this - #1373, which is merged, should mean that the validators are set on ResponseInitChain according to their power.

Have we tried just removing the assertion (or is it Tendermint-side)?

edit: Aha, see tendermint/tendermint#2015.

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

Ref #1840 once upstream is updated.

@rigelrozanski rigelrozanski merged commit 6c7e17a into develop Jul 26, 2018
@rigelrozanski rigelrozanski deleted the rigel/server-fix branch July 26, 2018 20:16
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
* fix: use bond_denom as default globalfee denom

* fix: fee test by setup uatom as staking bond denom

* chore: update error logs

* fix: subspace notfound err type

* test: add test for defaultGlobalFee

* chore: return error for DefaultZeroGlobalFee

* refactor: move FeeDecorator methods from fee_utils.go to fee.go

* fix: use SetParamSet rather than set when setting bondDenom

* chore: code improvement

* fix: move panic to antehandler

Co-authored-by: Danilo Pantani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't start the gaiad by the previous command
5 participants