-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP fix gen-tx #1824
WIP fix gen-tx #1824
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1824 +/- ##
===========================================
- Coverage 63.44% 63.42% -0.02%
===========================================
Files 117 117
Lines 6938 6940 +2
===========================================
Hits 4402 4402
- Misses 2281 2283 +2
Partials 255 255 |
This also breaks the @cwgoes does this relate to what I brought up earlier? Something along the lines of |
Huh I don't think we ought to need this - #1373, which is merged, should mean that the validators are set on Have we tried just removing the assertion (or is it Tendermint-side)? edit: Aha, see tendermint/tendermint#2015. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK
Ref #1840 once upstream is updated.
* fix: use bond_denom as default globalfee denom * fix: fee test by setup uatom as staking bond denom * chore: update error logs * fix: subspace notfound err type * test: add test for defaultGlobalFee * chore: return error for DefaultZeroGlobalFee * refactor: move FeeDecorator methods from fee_utils.go to fee.go * fix: use SetParamSet rather than set when setting bondDenom * chore: code improvement * fix: move panic to antehandler Co-authored-by: Danilo Pantani <[email protected]>
This PR should close #1804
breaking changes were made in #1373 which broke the
gen-tx
mechanism in init.Example commands which demonstrate the break:
That final error should not be occurring. (basically non of the validators from any
gen-tx
are being processed and added to the genesis.json)The current roll-back (aka my first commit here) has the Tendermint validators in the genesis file, which I think we've already removed? Not totally sure, I'm assuming that still needs to be updated in this PR @mossid
docs/
)PENDING.md
cmd/gaia
andexamples/
For Admin Use: