Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(x/staking): implement RotateConsPubKey method #18188

Merged
merged 73 commits into from
Nov 15, 2023
Merged

feat(x/staking): implement RotateConsPubKey method #18188

Show file tree
Hide file tree
Changes from 69 commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
b6b512a
feat: implement rotate cons key method in msg server
atheeshp Oct 20, 2023
7c7322a
fix tests
atheeshp Oct 24, 2023
9aef4f4
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Oct 24, 2023
37675e6
fix tests
atheeshp Oct 24, 2023
a9be784
fix tests
atheeshp Oct 24, 2023
2a713b5
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Oct 24, 2023
43923ce
go mod tidy
atheeshp Oct 24, 2023
d674890
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Oct 24, 2023
20f27b7
Merge branch 'main' into ap/add-msg-srvr-code
atheeshp Oct 25, 2023
a51cca3
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Oct 25, 2023
cacc0d8
go mod
atheeshp Oct 25, 2023
e9231e4
Merge branch 'ap/add-msg-srvr-code' of github.com:cosmos/cosmos-sdk i…
atheeshp Oct 25, 2023
5086c5f
fix lint
atheeshp Oct 26, 2023
202e2ef
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Oct 26, 2023
3b52332
review changes
atheeshp Oct 26, 2023
4843ae1
fix tests
atheeshp Oct 26, 2023
67e15e0
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Oct 27, 2023
8ffaa71
code rabbit review changes
atheeshp Oct 27, 2023
cce3c19
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Oct 30, 2023
4a63bde
conflicts
atheeshp Oct 30, 2023
4350e5b
review changes
atheeshp Oct 30, 2023
bbcb932
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Oct 30, 2023
7b2b9bd
fix tests
atheeshp Oct 31, 2023
6e8eb7f
review changes
atheeshp Oct 31, 2023
04f1cbe
Merge branch 'main' into ap/add-msg-srvr-code
atheeshp Oct 31, 2023
535d00f
review changes
atheeshp Oct 31, 2023
12274e9
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Oct 31, 2023
b19d163
Merge branch 'ap/add-msg-srvr-code' of github.com:cosmos/cosmos-sdk i…
atheeshp Oct 31, 2023
e463855
go mod
atheeshp Oct 31, 2023
552e683
go mod
atheeshp Oct 31, 2023
2ea32bc
fix go mod
atheeshp Oct 31, 2023
fb3363f
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Oct 31, 2023
9976530
go mod
atheeshp Oct 31, 2023
d4439ec
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Nov 2, 2023
3a0f4da
review changes
atheeshp Nov 2, 2023
89ca04f
proto
atheeshp Nov 2, 2023
6d138b8
proto-gen
atheeshp Nov 2, 2023
49f1745
review changes
atheeshp Nov 2, 2023
4183c78
review changes
atheeshp Nov 2, 2023
327929f
proto-gen
atheeshp Nov 2, 2023
efb8022
review changes
atheeshp Nov 2, 2023
dfbb63a
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Nov 2, 2023
dd8c72c
review changes
atheeshp Nov 2, 2023
0359d96
review changes
atheeshp Nov 2, 2023
441f6ee
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Nov 3, 2023
f41fdf0
go mod tidy
atheeshp Nov 3, 2023
c7563f5
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Nov 6, 2023
44731ce
try fixing go mod
atheeshp Nov 6, 2023
8a00a07
fix go mod changes
atheeshp Nov 6, 2023
7ed213f
review change
atheeshp Nov 6, 2023
78c4eda
review changes
atheeshp Nov 6, 2023
b236334
review changes
atheeshp Nov 7, 2023
a4b06da
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Nov 7, 2023
cae4de4
clean comments
atheeshp Nov 7, 2023
1539aaa
review changes
atheeshp Nov 7, 2023
e30bece
Merge branch 'main' into ap/add-msg-srvr-code
atheeshp Nov 7, 2023
d4bf237
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Nov 7, 2023
20bf052
conflicts
atheeshp Nov 7, 2023
10f6e38
Merge branch 'ap/add-msg-srvr-code' of github.com:cosmos/cosmos-sdk i…
atheeshp Nov 7, 2023
d32c833
go mod tidy
atheeshp Nov 7, 2023
05e560a
review changes
atheeshp Nov 8, 2023
e27c72a
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Nov 8, 2023
09b5b5a
proto
atheeshp Nov 9, 2023
eaa35c3
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Nov 9, 2023
42a8b7f
proto-gen
atheeshp Nov 9, 2023
10c280d
reivew changes
atheeshp Nov 9, 2023
b44de9d
review changes
atheeshp Nov 9, 2023
da82fa2
proto
atheeshp Nov 9, 2023
4d5e362
proto-gen
atheeshp Nov 9, 2023
bc8085f
review changes
atheeshp Nov 14, 2023
45d97ef
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Nov 14, 2023
da671f1
review changes
atheeshp Nov 15, 2023
fe857a2
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/add-msg-s…
atheeshp Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 38 additions & 36 deletions api/cosmos/staking/v1beta1/staking.pulsar.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions api/cosmos/staking/v1beta1/tx_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion collections/indexes/multi_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ func TestMultiIndex(t *testing.T) {
return value.City, nil
})

// we crete two reference keys for primary key 1 and 2 associated with "milan"
// we create two reference keys for primary key 1 and 2 associated with "milan"
require.NoError(t, mi.Reference(ctx, 1, company{City: "milan"}, func() (company, error) { return company{}, collections.ErrNotFound }))
require.NoError(t, mi.Reference(ctx, 2, company{City: "milan"}, func() (company, error) { return company{}, collections.ErrNotFound }))

Expand Down
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ require (
)

require (
cosmossdk.io/x/distribution v0.0.0-20230925135524-a1bc045b3190 // indirect
filippo.io/edwards25519 v1.0.0 // indirect
github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect
github.com/DataDog/zstd v1.5.5 // indirect
Expand Down
4 changes: 2 additions & 2 deletions proto/cosmos/staking/v1beta1/staking.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@
option (gogoproto.goproto_getters) = false;

// operator_address defines the address of the validator's operator; bech encoded in JSON.
string operator_address = 1;
bytes operator_address = 1;

Check failure on line 418 in proto/cosmos/staking/v1beta1/staking.proto

View workflow job for this annotation

GitHub Actions / break-check 

Field "1" on message "ConsPubKeyRotationHistory" changed type from "string" to "bytes".
kocubinski marked this conversation as resolved.
Show resolved Hide resolved
// old_cons_pubkey is the old consensus public key of the validator, as a Protobuf Any.
google.protobuf.Any old_cons_pubkey = 2 [(cosmos_proto.accepts_interface) = "cosmos.crypto.PubKey"];
// new_cons_pubkey is the new consensus public key of the validator, as a Protobuf Any.
Expand All @@ -429,5 +429,5 @@
// ValAddrsOfRotatedConsKeys contains the array of validator addresses which rotated their keys
// This is to block the validator's next rotation till unbonding period.
message ValAddrsOfRotatedConsKeys {
repeated string addresses = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];
repeated bytes addresses = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];

Check failure on line 432 in proto/cosmos/staking/v1beta1/staking.proto

View workflow job for this annotation

GitHub Actions / break-check 

Field "1" on message "ValAddrsOfRotatedConsKeys" changed type from "string" to "bytes".
tac0turtle marked this conversation as resolved.
Show resolved Hide resolved
}
2 changes: 1 addition & 1 deletion proto/cosmos/staking/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ service Msg {

// RotateConsPubKey defines an operation for rotating the consensus keys
// of a validator.
// Since: cosmos-sdk 0.48
// Since: cosmos-sdk 0.51
rpc RotateConsPubKey(MsgRotateConsPubKey) returns (MsgRotateConsPubKeyResponse);
}

Expand Down
1 change: 1 addition & 0 deletions x/auth/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ require (
)

require (
cosmossdk.io/x/distribution v0.0.0-20230925135524-a1bc045b3190 // indirect
filippo.io/edwards25519 v1.0.0 // indirect
github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect
github.com/99designs/keyring v1.2.1 // indirect
Expand Down
1 change: 1 addition & 0 deletions x/authz/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ require (
require (
cosmossdk.io/collections v0.4.0 // indirect
cosmossdk.io/x/auth v0.0.0-00010101000000-000000000000
cosmossdk.io/x/distribution v0.0.0-20230925135524-a1bc045b3190 // indirect
cosmossdk.io/x/protocolpool v0.0.0-20230925135524-a1bc045b3190 // indirect
filippo.io/edwards25519 v1.0.0 // indirect
github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect
Expand Down
1 change: 1 addition & 0 deletions x/bank/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ require (

require (
cosmossdk.io/x/auth v0.0.0-00010101000000-000000000000
cosmossdk.io/x/distribution v0.0.0-20230925135524-a1bc045b3190 // indirect
cosmossdk.io/x/tx v0.12.0 // indirect
filippo.io/edwards25519 v1.0.0 // indirect
github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect
Expand Down
1 change: 1 addition & 0 deletions x/evidence/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ require (
)

require (
cosmossdk.io/x/distribution v0.0.0-20230925135524-a1bc045b3190 // indirect
cosmossdk.io/x/gov v0.0.0-20230925135524-a1bc045b3190 // indirect
cosmossdk.io/x/tx v0.12.0 // indirect
filippo.io/edwards25519 v1.0.0 // indirect
Expand Down
1 change: 1 addition & 0 deletions x/feegrant/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ require (

require (
cosmossdk.io/x/auth v0.0.0-00010101000000-000000000000
cosmossdk.io/x/distribution v0.0.0-20230925135524-a1bc045b3190 // indirect
cosmossdk.io/x/tx v0.12.0 // indirect
filippo.io/edwards25519 v1.0.0 // indirect
github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect
Expand Down
1 change: 1 addition & 0 deletions x/gov/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ require (

require (
cosmossdk.io/x/auth v0.0.0-00010101000000-000000000000
cosmossdk.io/x/distribution v0.0.0-20230925135524-a1bc045b3190 // indirect
cosmossdk.io/x/tx v0.12.0 // indirect
filippo.io/edwards25519 v1.0.0 // indirect
github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect
Expand Down
1 change: 1 addition & 0 deletions x/group/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ require (

require (
cosmossdk.io/collections v0.4.0 // indirect
cosmossdk.io/x/distribution v0.0.0-20230925135524-a1bc045b3190 // indirect
cosmossdk.io/x/tx v0.12.0 // indirect
filippo.io/edwards25519 v1.0.0 // indirect
github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect
Expand Down
Loading
Loading