Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(store/v2): API tweaks and cleanup #17995

Merged
merged 5 commits into from
Oct 6, 2023

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Oct 6, 2023

Description

closes: #17989
closes: #17988


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez changed the title chore (store v2): API tweaks and cleanup chore(store v2): API tweaks and cleanup Oct 6, 2023
@alexanderbez alexanderbez changed the title chore(store v2): API tweaks and cleanup chore(store/v2): API tweaks and cleanup Oct 6, 2023
@alexanderbez alexanderbez marked this pull request as ready for review October 6, 2023 18:16
@alexanderbez alexanderbez requested a review from a team as a code owner October 6, 2023 18:16
@alexanderbez alexanderbez merged commit 3428c09 into feature/store-v2 Oct 6, 2023
47 of 50 checks passed
@alexanderbez alexanderbez deleted the bez/store-v2-updates branch October 6, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant