Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Banner in readme was missing #17839

Merged
merged 2 commits into from
Sep 22, 2023
Merged

docs: Banner in readme was missing #17839

merged 2 commits into from
Sep 22, 2023

Conversation

facundomedica
Copy link
Member

Description

Thanks to Mary from IBC team for reporting! :)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@facundomedica facundomedica requested a review from a team as a code owner September 22, 2023 10:59
@github-prbot github-prbot requested review from a team, kocubinski and tac0turtle and removed request for a team September 22, 2023 10:59
@julienrbrt julienrbrt changed the title fix: Banner in readme was missing docs: Banner in readme was missing Sep 22, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit d325b74 Sep 22, 2023
@julienrbrt julienrbrt deleted the facu/fix-banner branch September 22, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants