Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename develop to learn #17821

Merged
merged 3 commits into from
Sep 21, 2023
Merged

chore: rename develop to learn #17821

merged 3 commits into from
Sep 21, 2023

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Sep 20, 2023 •
edited
Loading

Description

discussed in slack that develop would be changed to learn

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Sep 20, 2023
@tac0turtle tac0turtle changed the title chore: rename build to learn chore: rename develop to learn Sep 20, 2023
@tac0turtle tac0turtle marked this pull request as ready for review September 20, 2023 14:03
@tac0turtle tac0turtle requested review from julienrbrt and a team as code owners September 20, 2023 14:03
@github-prbot github-prbot requested review from a team and atheeshp and removed request for a team September 20, 2023 14:09
@julienrbrt
Copy link
Member

julienrbrt commented Sep 20, 2023 •
edited
Loading

Can we update the pre.sh/post.sh scripts? It copies to develop/ as well.
EDIT: oh you already did it, missed that on my phone.

@tac0turtle tac0turtle added this pull request to the merge queue Sep 21, 2023
@tac0turtle
Copy link
Member Author

links are breaking but ill follow up on this

Merged via the queue into main with commit 2efafee Sep 21, 2023
41 of 42 checks passed
@tac0turtle tac0turtle deleted the marko/rename branch September 21, 2023 09:29
mergify bot pushed a commit that referenced this pull request Sep 21, 2023
@tac0turtle @mergify
chore: rename develop to learn (#17821)
0b800f7 
(cherry picked from commit 2efafee)

# Conflicts:
#	.github/workflows/md-link-checker.yml
#	docs/.gitignore
#	docs/develop/advanced/00-baseapp.md
#	docs/develop/advanced/01-transactions.md
#	docs/develop/advanced/02-context.md
#	docs/develop/advanced/03-node.md
#	docs/develop/advanced/04-store.md
#	docs/develop/advanced/05-encoding.md
#	docs/develop/advanced/06-grpc_rest.md
#	docs/develop/advanced/07-cli.md
#	docs/develop/advanced/08-events.md
#	docs/develop/advanced/09-telemetry.md
#	docs/develop/advanced/10-ocap.md
#	docs/develop/advanced/11-runtx_middleware.md
#	docs/develop/advanced/12-simulation.md
#	docs/develop/advanced/13-proto-docs.md
#	docs/develop/advanced/15-upgrade.md
#	docs/develop/advanced/16-config.md
#	docs/develop/advanced/_category_.json
#	docs/develop/advanced/baseapp_state-begin_block.png
#	docs/develop/advanced/baseapp_state-checktx.png
#	docs/develop/advanced/baseapp_state-commit.png
#	docs/develop/advanced/baseapp_state-deliver_tx.png
#	docs/develop/advanced/baseapp_state-initchain.png
#	docs/develop/advanced/baseapp_state-prepareproposal.png
#	docs/develop/advanced/baseapp_state-processproposal.png
#	docs/develop/advanced/baseapp_state.png
#	docs/develop/beginner/00-app-anatomy.md
#	docs/develop/beginner/01-tx-lifecycle.md
#	docs/develop/beginner/02-query-lifecycle.md
#	docs/develop/beginner/03-accounts.md
#	docs/develop/beginner/04-gas-fees.md
#	docs/develop/beginner/_category_.json
#	docs/develop/intro/00-overview.md
#	docs/develop/intro/01-why-app-specific.md
#	docs/develop/intro/02-sdk-app-architecture.md
#	docs/develop/intro/03-sdk-design.md
#	docs/develop/intro/_category_.json
#	docs/docs/build/building-modules/06-keeper.md
#	docs/docs/develop/advanced/00-baseapp.md
#	docs/docs/develop/advanced/01-transactions.md
#	docs/docs/develop/advanced/02-context.md
#	docs/docs/develop/advanced/03-node.md
#	docs/docs/develop/advanced/04-store.md
#	docs/docs/develop/advanced/05-encoding.md
#	docs/docs/develop/advanced/06-grpc_rest.md
#	docs/docs/develop/advanced/07-cli.md
#	docs/docs/develop/advanced/08-events.md
#	docs/docs/develop/advanced/09-telemetry.md
#	docs/docs/develop/advanced/10-ocap.md
#	docs/docs/develop/advanced/11-runtx_middleware.md
#	docs/docs/develop/advanced/12-simulation.md
#	docs/docs/develop/advanced/13-proto-docs.md
#	docs/docs/develop/advanced/15-upgrade.md
#	docs/docs/develop/advanced/16-config.md
#	docs/docs/develop/advanced/_category_.json
#	docs/docs/develop/advanced/baseapp_state-begin_block.png
#	docs/docs/develop/advanced/baseapp_state-checktx.png
#	docs/docs/develop/advanced/baseapp_state-commit.png
#	docs/docs/develop/advanced/baseapp_state-deliver_tx.png
#	docs/docs/develop/advanced/baseapp_state-initchain.png
#	docs/docs/develop/advanced/baseapp_state-prepareproposal.png
#	docs/docs/develop/advanced/baseapp_state-processproposal.png
#	docs/docs/develop/advanced/baseapp_state.png
#	docs/docs/develop/beginner/00-app-anatomy.md
#	docs/docs/develop/beginner/01-tx-lifecycle.md
#	docs/docs/develop/beginner/02-query-lifecycle.md
#	docs/docs/develop/beginner/03-accounts.md
#	docs/docs/develop/beginner/04-gas-fees.md
#	docs/docs/develop/beginner/_category_.json
#	docs/docs/develop/intro/00-what-is-sdk.md
#	docs/docs/develop/intro/01-why-app-specific.md
#	docs/docs/develop/intro/02-sdk-app-architecture.md
#	docs/docs/develop/intro/03-sdk-design.md
#	docs/docs/develop/intro/_category_.json
#	docs/learn/advanced/00-baseapp.md
#	docs/learn/advanced/01-transactions.md
#	docs/learn/advanced/02-context.md
#	docs/learn/advanced/03-node.md
#	docs/learn/advanced/04-store.md
#	docs/learn/advanced/05-encoding.md
#	docs/learn/advanced/06-grpc_rest.md
#	docs/learn/advanced/07-cli.md
#	docs/learn/advanced/08-events.md
#	docs/learn/advanced/09-telemetry.md
#	docs/learn/advanced/10-ocap.md
#	docs/learn/advanced/11-runtx_middleware.md
#	docs/learn/advanced/12-simulation.md
#	docs/learn/advanced/13-proto-docs.md
#	docs/learn/advanced/15-upgrade.md
#	docs/learn/advanced/16-config.md
#	docs/learn/advanced/_category_.json
#	docs/learn/advanced/baseapp_state-begin_block.png
#	docs/learn/advanced/baseapp_state-checktx.png
#	docs/learn/advanced/baseapp_state-commit.png
#	docs/learn/advanced/baseapp_state-deliver_tx.png
#	docs/learn/advanced/baseapp_state-initchain.png
#	docs/learn/advanced/baseapp_state-prepareproposal.png
#	docs/learn/advanced/baseapp_state-processproposal.png
#	docs/learn/advanced/baseapp_state.png
#	docs/learn/beginner/00-app-anatomy.md
#	docs/learn/beginner/01-tx-lifecycle.md
#	docs/learn/beginner/02-query-lifecycle.md
#	docs/learn/beginner/03-accounts.md
#	docs/learn/beginner/04-gas-fees.md
#	docs/learn/beginner/_category_.json
#	docs/learn/intro/00-overview.md
#	docs/learn/intro/01-why-app-specific.md
#	docs/learn/intro/02-sdk-app-architecture.md
#	docs/learn/intro/03-sdk-design.md
#	docs/learn/intro/_category_.json
#	docs/post.sh
#	docs/pre.sh
@mergify mergify bot mentioned this pull request Sep 21, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Sep 21, 2023
@mergify @tac0turtle
chore: rename develop to learn (backport #17821) (#17830)
cdd7d8c 
Co-authored-by: Marko <[email protected]>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@atheeshp atheeshp Awaiting requested review from atheeshp

Assignees

@samricotta samricotta

Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release Type: ADR Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tac0turtle @julienrbrt @samricotta