Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove bank & genutil legacy migrations #17818

Merged
merged 12 commits into from
Sep 21, 2023
Merged

chore!: remove bank & genutil legacy migrations #17818

merged 12 commits into from
Sep 21, 2023

Conversation

tac0turtle
Copy link
Member

Description

ref #17360

This is the first pr of removing legacy migrations in order to remove param module as a dependency from all modules

This pr only touches bank and genutil. Ill break up the prs in order to make them easier to review


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:CLI C:x/bank C:x/genutil genutil module issues labels Sep 20, 2023
@tac0turtle tac0turtle marked this pull request as ready for review September 20, 2023 12:46
@tac0turtle tac0turtle requested a review from a team as a code owner September 20, 2023 12:46
@github-prbot github-prbot requested review from a team, kocubinski and samricotta and removed request for a team September 20, 2023 12:49
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like when In see red in diff :D

x/bank/module.go Show resolved Hide resolved
@julienrbrt julienrbrt changed the title chore: remove bank & genutil legacy migrations chore!: remove bank & genutil legacy migrations Sep 20, 2023
@tac0turtle tac0turtle disabled auto-merge September 21, 2023 09:08
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels so good to see this much red 😆

@tac0turtle tac0turtle added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 5987d00 Sep 21, 2023
43 of 48 checks passed
@tac0turtle tac0turtle deleted the marko/17360_1 branch September 21, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants