Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/gov: fix the bug about turning VoteOption byte to String #1757

Merged
merged 1 commit into from
Jul 19, 2018
Merged

x/gov: fix the bug about turning VoteOption byte to String #1757

merged 1 commit into from
Jul 19, 2018

Conversation

MrXJC
Copy link
Contributor

@MrXJC MrXJC commented Jul 19, 2018 •
edited
Loading

close #1756
All details in #1756.

  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 19, 2018

Codecov Report

Merging #1757 into develop will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           develop    #1757   +/-   ##
========================================
  Coverage    64.16%   64.16%           
========================================
  Files          115      115           
  Lines         6837     6837           
========================================
  Hits          4387     4387           
  Misses        2196     2196           
  Partials       254      254

ebuchman
ebuchman approved these changes Jul 19, 2018
View reviewed changes
Copy link
Member

@ebuchman ebuchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ebuchman ebuchman merged commit 7dd0e3f into cosmos:develop Jul 19, 2018
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
@okwme
update docs for joining mainnet (cosmos#1757)
f4339cb 
* update docs for joining mainnet

* undo auto-markdown formatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebuchman ebuchman ebuchman approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/gov:the error about turning VoteOption byte to String.
2 participants
@MrXJC @ebuchman