Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(math): fix panic in .Size() #17480

Merged
merged 4 commits into from
Aug 21, 2023
Merged

fix(math): fix panic in .Size() #17480

merged 4 commits into from
Aug 21, 2023

Conversation

julienrbrt
Copy link
Member

Description

.Size() panics in the new math/v1.1.0 when there Int is nil:

cf: https://github.com/cosmos/cosmos-sdk/actions/runs/5921098375/job/16053189698?pr=17472

After this PR I'll tag v1.1.1.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Contributor

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question.

@@ -442,6 +442,10 @@ var (
)

func (i *Int) Size() (size int) {
if i == nil || i.i == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julienrbrt wondering where the "return 1" comes from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the result of (&math.Int{}).Size() on math/v1.0.1

@testinginprod testinginprod self-requested a review August 21, 2023 09:02
Copy link
Contributor

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to approve 🙏

@julienrbrt julienrbrt added this pull request to the merge queue Aug 21, 2023
Merged via the queue into main with commit 1089f71 Aug 21, 2023
40 of 46 checks passed
@julienrbrt julienrbrt deleted the julien/math-panic branch August 21, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants