Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(math): defend NewIntFromBigInt argument mutation #17352

Merged
merged 4 commits into from
Aug 10, 2023
Merged

fix(math): defend NewIntFromBigInt argument mutation #17352

merged 4 commits into from
Aug 10, 2023

Conversation

alexanderbez
Copy link
Contributor

Description

Closes: #17342

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez marked this pull request as ready for review August 10, 2023 16:01
@alexanderbez alexanderbez requested a review from a team as a code owner August 10, 2023 16:01
@github-prbot github-prbot requested review from a team, tac0turtle and julienrbrt and removed request for a team August 10, 2023 16:01
@alexanderbez alexanderbez enabled auto-merge August 10, 2023 16:01
@alexanderbez alexanderbez added the C:math Component: Math label Aug 10, 2023
julienrbrt
julienrbrt reviewed Aug 10, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@julienrbrt julienrbrt changed the title fix: defend NewIntFromBigInt argument mutation fix(math): defend NewIntFromBigInt argument mutation Aug 10, 2023
julienrbrt
julienrbrt approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

math/int_test.go Outdated Show resolved Hide resolved
@alexanderbez alexanderbez added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit 658a88a Aug 10, 2023
1 check passed
@alexanderbez alexanderbez deleted the bez/fix-17342 branch August 10, 2023 20:12
@facundomedica facundomedica mentioned this pull request Oct 23, 2023
Merged
20 tasks
@facundomedica facundomedica added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Oct 23, 2023
mergify bot pushed a commit that referenced this pull request Oct 23, 2023
@alexanderbez @mergify
fix(math): defend NewIntFromBigInt argument mutation (#17352)
d48a3f8 
(cherry picked from commit 658a88a)

# Conflicts:
#	math/CHANGELOG.md
@mergify mergify bot mentioned this pull request Oct 23, 2023
Closed
@dusan-maksimovic dusan-maksimovic mentioned this pull request Jan 30, 2024
Merged
12 tasks
mpoke pushed a commit that referenced this pull request Jan 31, 2024
@dusan-maksimovic
fix(math): Backport of pull requests #17352 and #18214 to feature/v.0…
17d5f73 
….47.x-ics-lsm branch (#19293)
mattverse pushed a commit to osmosis-labs/cosmos-sdk that referenced this pull request Feb 6, 2024
@dusan-maksimovic @mattverse
fix(math): Backport of pull requests cosmos#17352 and cosmos#18214 to…
856c280 
… feature/v.0.47.x-ics-lsm branch (cosmos#19293)
stana-miric added a commit to informalsystems/cosmos-sdk that referenced this pull request Jun 13, 2024
@stana-miric
fix(math): Backport of pull requests cosmos#17352 and cosmos#18214
e76481f
@stana-miric stana-miric mentioned this pull request Jun 13, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:math Component: Math
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: NewIntFromBigInt does not actually construct a new Int from the input
3 participants
@alexanderbez @julienrbrt @facundomedica