-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/staking): migrate RedelegationByValDstIndexKey key to collections #17336
Conversation
…ion-key-to-collections
…ion-key-to-collections
…ion-key-to-collections
…ion-key-to-collections
…s/cosmos-sdk into ap/redelegation-key-to-collections
…s/cosmos-sdk into ap/red-from-val-dst-to-coll
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, DiffCollectionsMigration
test passes 👌
x/staking/types/keys.go
Outdated
|
||
return key | ||
} | ||
|
||
// GetREDKeyFromValSrcIndexKey rearranges the ValSrcIndexKey to get the REDKey | ||
func GetREDKeyFromValSrcIndexKey(indexKey []byte) []byte { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removed in other branch of migrating REDKeyFromValSrcIndexKey
to collections (here: #17332)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left one question
Where can I find a test showing that the state changes produced in this migration are the same as the previous code path? |
Was added here: https://github.com/cosmos/cosmos-sdk/pull/17336/files#diff-b751d8b426a3bbcb08ccee5040c1eff9f0ec8d88bde9103506ae1bf8767d6b25R140 |
…s-sdk into ap/red-from-val-dst-to-coll
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed it, will raise a PR.
Description
Closes: #16384
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change