Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/staking): migrate UnbondingType to collections #17248

Merged
merged 11 commits into from
Aug 3, 2023

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #16388


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 marked this pull request as ready for review August 1, 2023 12:02
@likhita-809 likhita-809 requested a review from a team as a code owner August 1, 2023 12:02
@github-prbot github-prbot requested review from a team, alexanderbez and julienrbrt and removed request for a team August 1, 2023 12:03
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look backwards compatible, we should store a uint64 instead of int64.

-- KEY: 390000000000000063 Value: 0000000000000001 
++ KEY: 390000000000000063 Value: 8000000000000001 

I suggest you check with this to find if your changes are compatible:

func (s *KeeperTestSuite) TestColls() {
	s.SetupTest()

	err := sdktestutil.DiffCollectionsMigration(
		s.ctx,
		s.key,
		100,
		func(i int64) {
			err := s.stakingKeeper.SetUnbondingType(
				s.ctx,
				uint64(i),
				types.UnbondingType_UnbondingDelegation,
			)
			s.Require().NoError(err)
		},
		"{insert original hash here}",
	)

	s.Require().NoError(err)
}

x/staking/keeper/unbonding.go Outdated Show resolved Hide resolved
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe not for this PR but it would be good to explore the possibility to make UnbondingType a uint64 instead of int, so we don't have to type cast and we wouldn't need GetUnbondingType and SetUnbondingType.

CHANGELOG.md Show resolved Hide resolved
x/staking/keeper/unbonding.go Show resolved Hide resolved
@likhita-809 likhita-809 requested a review from julienrbrt August 2, 2023 09:16
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, one nit.

x/staking/keeper/unbonding.go Outdated Show resolved Hide resolved
@julienrbrt
Copy link
Member

Could you fix the conflicts?

@julienrbrt julienrbrt enabled auto-merge August 3, 2023 09:03
@julienrbrt julienrbrt added this pull request to the merge queue Aug 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 3, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Aug 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 3, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit a7977b8 Aug 3, 2023
@julienrbrt julienrbrt deleted the likhita/ubdtype-coll branch August 3, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(staking): move UnbondingType to use collections
3 participants