Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Better describe ABCI-exposed /key and /subspace store APIs #17231

Merged
merged 2 commits into from
Aug 1, 2023
Merged

docs: Better describe ABCI-exposed /key and /subspace store APIs #17231

merged 2 commits into from
Aug 1, 2023

Conversation

gibson042
Copy link
Contributor

Description

Clarifies the valid paths for ABCI "/store/…" requests.

Author Checklist

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • [not applicable] provided a link to the relevant issue or specification
  • followed the documentation writing guidelines
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct docs: prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR only changes documentation
  • reviewed content for consistency
  • reviewed content for thoroughness
  • reviewed content for spelling and grammar
  • tested instructions (if applicable)

@gibson042 gibson042 requested a review from a team as a code owner July 31, 2023 21:28
samricotta
samricotta approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@samricotta samricotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! thanks for that

@samricotta samricotta added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Aug 1, 2023
julienrbrt
julienrbrt approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@julienrbrt julienrbrt added this pull request to the merge queue Aug 1, 2023
Merged via the queue into cosmos:main with commit 63113e8 Aug 1, 2023
42 checks passed
mergify bot pushed a commit that referenced this pull request Aug 1, 2023
@gibson042 @mergify
docs: Better describe ABCI-exposed /key and /subspace store APIs (#17231
bb90207 
)

(cherry picked from commit 63113e8)
@mergify mergify bot mentioned this pull request Aug 1, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Aug 1, 2023
@mergify
docs: Better describe ABCI-exposed /key and /subspace store APIs (bac…
e9ee747 
…kport #17231) (#17255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@samricotta samricotta samricotta approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@atheeshp atheeshp Awaiting requested review from atheeshp

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gibson042 @julienrbrt @samricotta