Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/staking): migrate delegation key to collections #17162

Merged
merged 27 commits into from
Aug 9, 2023

Conversation

atheeshp
Copy link
Contributor

Description

Closes: #16380


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp changed the title WIP: migrate delegation key to collections refactor(WIP): migrate delegation key to collections Jul 27, 2023
@atheeshp atheeshp marked this pull request as ready for review August 1, 2023 10:48
@atheeshp atheeshp requested a review from a team as a code owner August 1, 2023 10:48
@atheeshp atheeshp changed the title refactor(WIP): migrate delegation key to collections refactor(x/staking): migrate delegation key to collections Aug 2, 2023
x/staking/keeper/grpc_query.go Show resolved Hide resolved
x/staking/testutil/helpers.go Outdated Show resolved Hide resolved
x/staking/types/keys.go Show resolved Hide resolved
x/staking/types/keys.go Show resolved Hide resolved
@facundomedica
Copy link
Member

lgtm so far, let's fix what Julien pointed out

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, one nit.

x/staking/keeper/grpc_query.go Outdated Show resolved Hide resolved
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, everything else lgtm

x/staking/keeper/alias_functions.go Outdated Show resolved Hide resolved
x/staking/keeper/alias_functions.go Outdated Show resolved Hide resolved
@atheeshp atheeshp added this pull request to the merge queue Aug 9, 2023
Merged via the queue into main with commit f907a27 Aug 9, 2023
48 checks passed
@atheeshp atheeshp deleted the ap/delegation-key-collections branch August 9, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(staking): move DelegationKey to use collections
3 participants