Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(x/staking): migrate historicalInfo to use collections #17063

Merged
merged 21 commits into from
Jul 25, 2023
Merged

refactor(x/staking): migrate historicalInfo to use collections #17063

merged 21 commits into from
Jul 25, 2023

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jul 19, 2023 •
edited
Loading

Description

ref: #14300
Closes: #16374

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp changed the title refactor (x/staking): migrate historicalInfo to use collections refactor: (x/staking) migrate historicalInfo to use collections Jul 19, 2023
@atheeshp atheeshp marked this pull request as ready for review July 19, 2023 11:17
@atheeshp atheeshp requested a review from a team as a code owner July 19, 2023 11:17
julienrbrt
julienrbrt reviewed Jul 21, 2023
View reviewed changes
x/staking/types/keys.go Outdated Show resolved Hide resolved
testinginprod
testinginprod requested changes Jul 21, 2023
View reviewed changes
x/staking/types/keys.go Outdated Show resolved Hide resolved
x/staking/keeper/keeper.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt changed the title refactor: (x/staking) migrate historicalInfo to use collections refactor(x/staking): migrate historicalInfo to use collections Jul 25, 2023
testinginprod
testinginprod reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@testinginprod testinginprod left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove: IterateHistoricalInfo. and also types.UnmarshalHistoricalInfo.

Can GetAllHistoricalInfo be removed also, I see it being used in a test only, so we can remove this method + the test?

testinginprod
testinginprod approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

julienrbrt
julienrbrt approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

x/staking/keeper/historical_info.go Outdated
@@ -123,7 +52,7 @@ func (k Keeper) TrackHistoricalInfo(ctx context.Context) error {
}

historicalEntry := types.NewHistoricalInfo(sdkCtx.BlockHeader(), lastVals, k.PowerReduction(ctx))

err = k.HistoricalInfo.Set(ctx, uint64(sdkCtx.BlockHeight()), historicalEntry)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: one liner

@atheeshp atheeshp enabled auto-merge July 25, 2023 08:54
@atheeshp atheeshp added this pull request to the merge queue Jul 25, 2023
Merged via the queue into main with commit c74e288 Jul 25, 2023
47 of 48 checks passed
@atheeshp atheeshp deleted the ap/historical-info-collections branch July 25, 2023 09:07
@coderabbitai coderabbitai bot mentioned this pull request Apr 22, 2024
Merged
12 tasks
This was referenced May 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@testinginprod testinginprod testinginprod approved these changes

Assignees
No one assigned
Labels
C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(staking): move Historical Info to use collections
4 participants
@atheeshp @alexanderbez @julienrbrt @testinginprod