Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/staking): migrate ValidatorUpdates to collections #17062

Merged
merged 6 commits into from
Jul 20, 2023

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #16373


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt changed the title refactor: Migrate ValidatorUpdates to collections refactor(x/staking): migrate ValidatorUpdates to collections Jul 19, 2023
@likhita-809 likhita-809 marked this pull request as ready for review July 19, 2023 08:58
@likhita-809 likhita-809 requested a review from a team as a code owner July 19, 2023 08:58
@github-prbot github-prbot requested review from a team, kocubinski and tac0turtle and removed request for a team July 19, 2023 08:58
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! However changelog is missing.

x/staking/keeper/keeper.go Show resolved Hide resolved
@julienrbrt julienrbrt added this pull request to the merge queue Jul 19, 2023
@julienrbrt julienrbrt removed this pull request from the merge queue due to a manual request Jul 19, 2023
@atheeshp
Copy link
Contributor

there is a failing test.

@julienrbrt julienrbrt added this pull request to the merge queue Jul 20, 2023
Merged via the queue into main with commit 535d711 Jul 20, 2023
@julienrbrt julienrbrt deleted the likhita/valupdates branch July 20, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(staking): move Validator Updates to use collections
5 participants