Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add gas meter #16310

Merged
merged 1 commit into from
May 30, 2023
Merged

feat(core): add gas meter #16310

merged 1 commit into from
May 30, 2023

Conversation

tac0turtle
Copy link
Member

Description

ref #14683

this pr adds gas meter to core api, in a follow up pr we will wire it into runtime


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle requested a review from a team as a code owner May 26, 2023 10:42
@github-actions
Copy link
Contributor

@tac0turtle your pull request is missing a changelog!

@julienrbrt julienrbrt changed the title feature: add gas meter to core feat(core): add gas meter May 28, 2023
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tac0turtle
Copy link
Member Author

merging for now, @aaronc any chance you can take a look at these though

@tac0turtle tac0turtle added this pull request to the merge queue May 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 30, 2023
@tac0turtle tac0turtle added this pull request to the merge queue May 30, 2023
Merged via the queue into main with commit 46c8ec8 May 30, 2023
@tac0turtle tac0turtle deleted the marko/core_gas_meter branch May 30, 2023 10:21
@coderabbitai coderabbitai bot mentioned this pull request May 3, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants