Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(x/auth): deprecate legacy aminojson sign mode #16110

Merged
merged 1 commit into from
May 11, 2023

Conversation

kocubinski
Copy link
Member

Description

Ref: #16094


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@kocubinski kocubinski requested a review from a team as a code owner May 11, 2023 14:49
@github-prbot github-prbot requested review from a team, mark-rushakoff and facundomedica and removed request for a team May 11, 2023 14:49
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated: needs to come at the start of a paragraph. Not sure this will actually get picked up by go tooling. Can you confirm whether it does work or update the doc comments @kocubinski ?

@kocubinski
Copy link
Member Author

kocubinski commented May 11, 2023

Deprecated: needs to come at the start of a paragraph. Not sure this will actually get picked up by go tooling. Can you confirm whether it does work or update the doc comments @kocubinski ?

Yes I can confirm that this works with tooling I am using. The strikethroughs indicate a deprecated method.

image image

@julienrbrt julienrbrt added this pull request to the merge queue May 11, 2023
Merged via the queue into main with commit e998532 May 11, 2023
@julienrbrt julienrbrt deleted the kocubinski/deprecate-legacy-aminojson branch May 11, 2023 16:51
@kocubinski kocubinski mentioned this pull request May 16, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants