Fix Infinite Feegrant Bug #16097
Merged
Fix Infinite Feegrant Bug #16097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is designed to reproduce an infinite Feegrant bug that occurs when using AllowedMsgAllowance with an internal BasicAllowance. I suspect that this line (https://github.com/scrtlabs/cosmos-sdk/blob/61091b357e/x/feegrant/basic_fee.go#L31) does not update the internal BasicAllowance after using part of the grant. This may be related to this line (https://github.com/scrtlabs/cosmos-sdk/blob/61091b357e/x/feegrant/filtered_fee.go#L47) as well.
The internal allowance update in AllowedMsgAllowance was never propagated to the parent AllowedMsgAllowance.
|
What is the impact of such bug? Given that v0.45.x is EOL, only security fixes are included in this branch. |
julienrbrt
approved these changes
May 11, 2023
tac0turtle
approved these changes
May 11, 2023
aaronc
approved these changes
May 11, 2023
alexanderbez
approved these changes
May 11, 2023
|
I'll update the changelog when making the release notes, merging now, so we can prepare the release. |
Sorry, next time! 😬 |
This was referenced May 11, 2023
This was referenced May 29, 2023
crypin
pushed a commit
to crescent-network/cosmos-sdk
that referenced
this pull request
Jun 8, 2023
(cherry picked from commit d3370f2) (cherry picked from commit 5b1bd64aaad9a679d5bc3d63f0770a4c64781cf5)
This was referenced Jun 8, 2023
19 tasks
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EDIT: Fix the bug. The internal allowance update was never propagated to the parent
AllowedMsgAllowance.This test is designed to reproduce an infinite Feegrant bug that occurs when using
AllowedMsgAllowancewith an internalBasicAllowance.I suspect that this line does not update the internal
BasicAllowanceafter using part of the grant. This may be related to this line as well.Thanks @DrPresident from Shade Protocol for initially reporting this issue.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change