Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(x/tx): Update changelog for x/tx v0.7.0 #16047

Closed
wants to merge 3 commits into from

Conversation

kocubinski
Copy link
Member

@kocubinski kocubinski commented May 5, 2023

Description

This will be tagged x/tx/v0.7.0


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@kocubinski kocubinski requested a review from a team as a code owner May 5, 2023 20:59
@github-actions github-actions bot added the C:x/tx label May 5, 2023
@aaronc
Copy link
Member

aaronc commented May 5, 2023

API breaking changes should result in a bump to 0.7.0. Let's address the other issues which will also require API breakage so that NewEncoder takes an Options struct and then we can bump to 0.7.0

@kocubinski
Copy link
Member Author

API breaking changes should result in a bump to 0.7.0. Let's address the other issues which will also require API breakage so that NewEncoder takes an Options struct and then we can bump to 0.7.0

I don't see NewEncoder Options related to this work stream, please review the latest in #16036 to see if this is acceptable.

@kocubinski kocubinski changed the title chore(x/tx): Update changelog for x/tx v0.6.3. chore(x/tx): Update changelog for x/tx v0.7.0 May 5, 2023
aminojson.marhsalAny now uses a fileResolver and dynamicpb instead of a typeResolver
@aaronc
Copy link
Member

aaronc commented May 5, 2023

API breaking changes should result in a bump to 0.7.0. Let's address the other issues which will also require API breakage so that NewEncoder takes an Options struct and then we can bump to 0.7.0

I don't see NewEncoder Options related to this work stream, please review the latest in #16036 to see if this is acceptable.

All that stuff should be handled in x/tx - it's what we promised we would deliver already. So it has higher priority

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@kocubinski
Copy link
Member Author

implemented in #16048

@kocubinski kocubinski closed this May 8, 2023
@julienrbrt julienrbrt deleted the kocubinski/x-tx-0.6.3 branch May 8, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants