refactor(client): Remove usage of GetSignBytes from AuxTxBuilder #16025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocubinski
force-pushed
the
kocubinski/deprecate-getsignbytes
branch
from
c2f6395
to
6631001
Compare
kocubinski
commented
May 4, 2023
| @@ -190,16 +212,43 @@ func (b *AuxTxBuilder) GetSignBytes() ([]byte, error) { | |||
| } | |||
| case signing.SignMode_SIGN_MODE_LEGACY_AMINO_JSON: | |||
| { | |||
| signBz = legacytx.StdSignBytes( | |||
There was a problem hiding this comment.
The key change in this PR, StdSignBytes calls legacyMsg.GetSignBytes, so we're now using the amino json signer in x/tx instead.
alexanderbez
approved these changes
May 4, 2023
aaronc
approved these changes
May 4, 2023
Pipello
reviewed
May 4, 2023
client/tx/aux_builder.go
Outdated
Comment on lines
128
to
131
| var err error | ||
| b.auxSignerData.Mode = mode | ||
|
|
||
| return nil | ||
| return err |
There was a problem hiding this comment.
looks like error is always gonna be nil no?
There was a problem hiding this comment.
Oops, definitely. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: #16024
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change