Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add valset change and block info service to runtime #15811

Merged
merged 11 commits into from
Apr 12, 2023

Conversation

tac0turtle
Copy link
Member

Description

ref #14683

This pr adds a block service api for information provided by comet. The interface grabs information from finalise block.

One thing we could add is a arbitrary byte string for other abci implementations like rollkit.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle requested a review from a team as a code owner April 12, 2023 10:40
@github-prbot github-prbot requested review from a team, JeancarloBarrios and likhita-809 and removed request for a team April 12, 2023 10:44
@github-actions
Copy link
Contributor

@tac0turtle your pull request is missing a changelog!

Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put any service that directly imports abci in runtime. The other stuff is maybe fine in core. We want to be able to tag core v1.0. That will be impossible with an abci dependency

core/go.mod Outdated Show resolved Hide resolved
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are services not extension interfaces. Important to make that clear

runtime/services.go Outdated Show resolved Hide resolved
runtime/services.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle changed the title feat: add valset change and block info service to core feat: add valset change and block info service to runtime Apr 12, 2023
@tac0turtle tac0turtle enabled auto-merge (squash) April 12, 2023 21:03
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 12, 2023
@tac0turtle tac0turtle merged commit f82cbbb into main Apr 12, 2023
@tac0turtle tac0turtle deleted the marko/core-api-val-block branch April 12, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. Type: ADR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants