Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: reduced golangci settings #15629

Closed
wants to merge 5 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Mar 30, 2023

Description

Works Toward: #15546


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat requested a review from a team as a code owner March 30, 2023 15:29
@faddat faddat mentioned this pull request Mar 30, 2023
19 tasks
@faddat
Copy link
Contributor Author

faddat commented Mar 30, 2023

@tac0turtle ok start here please

@github-prbot github-prbot requested review from a team, julienrbrt and samricotta and removed request for a team March 30, 2023 15:35
.golangci.yml Outdated Show resolved Hide resolved
@faddat faddat changed the title reduced golangci settings (will remove a few checks that are always nolinted) style: reduced golangci settings (will remove a few checks that are always nolinted) Mar 30, 2023
@faddat faddat changed the title style: reduced golangci settings (will remove a few checks that are always nolinted) style: reduced golangci settings Mar 30, 2023
.golangci.yml Show resolved Hide resolved
.golangci.yml Show resolved Hide resolved
@faddat faddat mentioned this pull request Mar 30, 2023
19 tasks
@julienrbrt
Copy link
Member

Closing as it was added here: #15631

@julienrbrt julienrbrt closed this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants