Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: linting #15620

Closed
wants to merge 31 commits into from
Closed

style: linting #15620

wants to merge 31 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Mar 30, 2023 •
edited
Loading

Description

This PR contains general-purpose linting :/

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat requested a review from a team as a code owner March 30, 2023 11:01
@github-actions github-actions bot added C:CLI C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:log C:orm C:Rosetta Issues and PR related to Rosetta labels Mar 30, 2023
@mergify mergify bot mentioned this pull request Mar 30, 2023
Closed
19 tasks
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql-analysis.yml:analyze. As part of the setup process, we have scanned this repository and found 242 existing alerts. Please check the repository Security tab to see all alerts.

@faddat
Copy link
Contributor Author

faddat commented Mar 30, 2023

I'll get rid of ... and that stutters on the inputs and outputs, 1 sec, this is why I was fleshing out the configs

@tac0turtle tac0turtle changed the title more style: linting Mar 30, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 30, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gosec found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@faddat faddat changed the base branch from marko/linting_4 to main March 30, 2023 12:34
@github-actions github-actions bot added C:Keys Keybase, KMS and HSMs C:x/genutil genutil module issues labels Mar 30, 2023
julienrbrt
julienrbrt reviewed Mar 30, 2023
View reviewed changes
.golangci.yml Outdated Show resolved Hide resolved
tac0turtle
tac0turtle reviewed Mar 30, 2023
View reviewed changes
.golangci.yml Outdated Show resolved Hide resolved
@tac0turtle
Copy link
Member

@faddat could you resolve conflicts then we can review and get this in

julienrbrt
julienrbrt requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments on the orm styling PR and for some reason there are orm changes here too..

orm/types/ormerrors/errors.go Outdated Show resolved Hide resolved
julienrbrt
julienrbrt reviewed Mar 30, 2023
View reviewed changes
orm/types/ormerrors/errors.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this as it is breaking. Some of my comments from orm here: #15610 still apply in this PR.

@tac0turtle
Copy link
Member

please keep files changed under 70 for easier review

@tac0turtle tac0turtle closed this Mar 30, 2023
@faddat
Copy link
Contributor Author

faddat commented Mar 31, 2023

deal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt requested changes

@tac0turtle tac0turtle tac0turtle left review comments

Assignees

@facundomedica facundomedica

@tac0turtle tac0turtle

@julienrbrt julienrbrt

Labels
C:CLI C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:Keys Keybase, KMS and HSMs C:log C:orm C:Rosetta Issues and PR related to Rosetta C:Simulations C:Store C:x/auth C:x/authz C:x/bank C:x/circuit C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/genutil genutil module issues C:x/gov C:x/group C:x/mint C:x/nft C:x/params C:x/slashing C:x/staking C:x/tx C:x/upgrade Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@faddat @tac0turtle @julienrbrt @facundomedica