-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(log): wire logger filtering #15601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
commented
Mar 29, 2023
github-actions
bot
added
C:Cosmovisor
Issues and PR related to Cosmovisor
C:log
C:Rosetta
Issues and PR related to Rosetta
labels
Mar 29, 2023
julienrbrt
changed the title
feat: wire logger filtering
feat(log): wire logger filtering
Mar 29, 2023
github-prbot
requested review from
a team,
aaronc and
JeancarloBarrios
and removed request for
a team
March 29, 2023 17:55
julienrbrt
requested review from
tac0turtle and
mark-rushakoff
and removed request for
aaronc and
JeancarloBarrios
March 29, 2023 18:21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple style details to clean up, but this otherwise looks all correct to me.
mark-rushakoff
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing those cleanups.
julienrbrt
force-pushed
the
julien/filter-logger
branch
from
March 29, 2023 19:52
8eadb57
to
2c3139a
Compare
julienrbrt
commented
Mar 30, 2023
tac0turtle
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:Cosmovisor
Issues and PR related to Cosmovisor
C:log
C:Rosetta
Issues and PR related to Rosetta
C:Store
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #15366
I have introduced log options, to make it more customizable and reduce the need of using
NewCustomLogger
for commonly used options.I like the UX of variadic options: it allows us to add functionalities, without being API breaking or adding a dozen constructors. It cleaned up the logger creation in server too.
After this PR, I will be tagging
cosmossdk.io/log
v1.0.0.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change